Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BottomNavigation] Use value over index #7421

Merged
merged 1 commit into from
Jul 13, 2017
Merged

[BottomNavigation] Use value over index #7421

merged 1 commit into from
Jul 13, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 12, 2017

Closes #2957 with the following breaking change:

-        <BottomNavigation index={index} onChange={this.handleChange}>
+        <BottomNavigation value={value} onChange={this.handleChange}>

I believe it's the only API that goes against the suggested one in the issue.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added component: bottom navigation This is the name of the generic UI component, not the React module! breaking change v1-alpha labels Jul 12, 2017
@oliviertassinari oliviertassinari merged commit 8c04c85 into mui:v1-alpha Jul 13, 2017
@oliviertassinari oliviertassinari deleted the docs-api-callbacks branch July 13, 2017 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: bottom navigation This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant