[Table] Row click on empty cell to not die in IE #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [TableBody] Row click on empty cell to not die in IE
|
That's breaking the build. I don't know much about that feature. I couldn't tell if it's the right fix or not. Still, I think that we can try to merge. Need to fix the build through and to make sure it's safe. |
oliviertassinari
added
component: table
* [TableBody] Check range count is greater than 0 before checking the 0th index node range
oliviertassinari
approved these changes
Jul 24, 2017
oliviertassinari
added
PR: Review Accepted
and removed
PR: needs revision
|
@Brianzchen Thanks |
djbuckley
added a commit
to manchesergit/material-ui
that referenced
this pull request
Jul 28, 2017
adam187
added a commit
to adam187/material-ui
that referenced
this pull request
Nov 21, 2017
…om-build * fix/broken-touch-scroll-on-nested-menu-items: [Menu] Ignore loosing focus on click away for item with menu items [examples] Remove browserify Fixes mui#7559 (mui#7560) [docs] Update ROADMAP (mui#7543) [Table] Row click on empty cell to not die in IE (mui#7520) Internal(EnhancedSwitch): fix checked prop (mui#7499) fix: comment typo (mui#7523) [Docs] Add v0.18.7 to versions.json v0.18.7 [CHANGELOG] Prepare v0.18.7 [ListItem] Fix triggers onTouchTap when disabled (mui#7486) [Popover] Scroll Container issue (mui#7472) [Table] Don't set height to tbody (mui#7484) docs: fix typo in Avatar readme (mui#7478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When selecting a row, if the cell selected is empty, an error will be thrown.
#3444