-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Renamed the styleSheet argument in withStyles to styles #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
phiilu
commented
Aug 18, 2017
- PR has tests / docs demo, and is linted.
- Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
- Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).
phiilu
changed the title
renamed the styleSheet argument in withStyles to styles
[Docs] Renamed the styleSheet argument in withStyles to styles
Aug 18, 2017
phiilu
changed the title
[Docs] Renamed the styleSheet argument in withStyles to styles
[docs] Renamed the styleSheet argument in withStyles to styles
Aug 18, 2017
oliviertassinari
approved these changes
Aug 18, 2017
oliviertassinari
added
docs
Improvements or additions to the documentation
PR: Review Accepted
labels
Aug 18, 2017
@phiilu Thanks |
No problem 😄 |
sebald
pushed a commit
that referenced
this pull request
Aug 23, 2017
oliviertassinari
pushed a commit
that referenced
this pull request
Aug 23, 2017
* [typescript] Add test for style overrides. * [typescript] Refactor typings to modules ...instead of ambient modules. * renamed the styleSheet argument in withStyles to styles (#7819) * [typescript] Create typings for TS when building. (#7820) * [core] Fix size-limit warning (#7822) * [icons] Automate release process (#7823) * [docs] Advanced table (#7824) * [icons] Fix release * [icons] Release v1.0.0-beta.5 * [core] Update some dependencies (#7831) * [icons] Update the dependencies * [core] Update some dependencies * [docs] Use next.js (#7759) * [RadioGroup] Rename selectedValue to value (#7832) * [core] Better usage of the CI 🚀 (#7833) * [TextField] Fix placeholder issue (#7838) * [docs] Add a ROADMAP page (#7840) * [docs] Add a team page (#7842) * [docs] Show inherited components (#7846) * [docs] Some last improvement before the release (#7847) * [CHANGELOG] Prepare v1.0.0-beta.6 * v1.0.0-beta.6 * [docs] Fix release script * [docs] Fix release script v2 * [docs] Small fixes after the next.js refactorization (#7851) * [docs] Fix missing props in css-in-js examples (#7867) * [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md * [typescript] Fix tests. * [build] Copy .d.ts files to build folder. * [typescript] Create module typings for icons. * [typescript] Lint.
Taldrain
pushed a commit
to Taldrain/material-ui
that referenced
this pull request
Aug 24, 2017
* [typescript] Add test for style overrides. * [typescript] Refactor typings to modules ...instead of ambient modules. * renamed the styleSheet argument in withStyles to styles (mui#7819) * [typescript] Create typings for TS when building. (mui#7820) * [core] Fix size-limit warning (mui#7822) * [icons] Automate release process (mui#7823) * [docs] Advanced table (mui#7824) * [icons] Fix release * [icons] Release v1.0.0-beta.5 * [core] Update some dependencies (mui#7831) * [icons] Update the dependencies * [core] Update some dependencies * [docs] Use next.js (mui#7759) * [RadioGroup] Rename selectedValue to value (mui#7832) * [core] Better usage of the CI 🚀 (mui#7833) * [TextField] Fix placeholder issue (mui#7838) * [docs] Add a ROADMAP page (mui#7840) * [docs] Add a team page (mui#7842) * [docs] Show inherited components (mui#7846) * [docs] Some last improvement before the release (mui#7847) * [CHANGELOG] Prepare v1.0.0-beta.6 * v1.0.0-beta.6 * [docs] Fix release script * [docs] Fix release script v2 * [docs] Small fixes after the next.js refactorization (mui#7851) * [docs] Fix missing props in css-in-js examples (mui#7867) * [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md * [typescript] Fix tests. * [build] Copy .d.ts files to build folder. * [typescript] Create module typings for icons. * [typescript] Lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.