Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[typescript] Update index and format #8076

Merged
merged 1 commit into from
Sep 7, 2017

Conversation

sebald
Copy link
Member

@sebald sebald commented Sep 7, 2017

@oliviertassinari typings of Select are perfect! The tests that failed were related to some other changes. Fixed them yesterday already. :)

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@oliviertassinari oliviertassinari merged commit 1c27fe1 into v1-beta Sep 7, 2017
@oliviertassinari oliviertassinari deleted the typings-update-index-formating branch September 7, 2017 09:57
@oliviertassinari oliviertassinari changed the title [typings] Update index and format. [typescript] Update index and format Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants