[Input] Dodge the BFcache issue #8110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Input/Input.js
Outdated
| /** | ||
| * @ignore | ||
| */ | ||
| onFocus?: Function, | ||
| onFocus?: (event: SyntheticUIEvent<>) => void, |
src/Input/Input.js
Outdated
| /** | ||
| * @ignore | ||
| */ | ||
| onKeyDown?: Function, | ||
| onKeyDown?: (event: SyntheticUIEvent<>) => void, |
|
FYI - I just figured out this change is not compatible with a custom |
src/Input/Input.js
Outdated
| const event = new Event('input', { | ||
| bubbles: true, | ||
| }); | ||
| this.input.dispatchEvent(event); |
There was a problem hiding this comment.
I have just tried it, it doesn't work. I'm looking into it.
|
I have opened an issue on the React side facebook/react#10657. Let's dodge the issue for now 👼 . |
oliviertassinari
force-pushed
the
input-events
branch
from
de48c81 to
5853b27
Compare
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
input-events
branch
from
5853b27 to
ae46767
Compare
oliviertassinari
added
component: select
oliviertassinari
force-pushed
the
input-events
branch
from
ae46767 to
b0ad8cb
Compare
oliviertassinari
force-pushed
the
input-events
branch
from
b0ad8cb to
4dac71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, the code on v1-beta is broken for users based on a hack for SSR.
I did some research, and successfully simulate the change in the browser.
@oliviertassinari this works in the browser, but it fails with mocha testing. Since I've gotten it this far (and I don't use SSR), I would appreciate if you picked this up and figured out the mocha dom Event compatibility issue and make sure it is SSR compatible for you.
I also more strongly typed the event signatures.
/reference https://stackoverflow.com/a/31056122/2363935