Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New List, ListItem, ListDivider, Avatar Components #836

Merged
merged 16 commits into from
Jun 13, 2015
Merged

Conversation

hai-cea
Copy link
Member

@hai-cea hai-cea commented Jun 13, 2015

No description provided.

@hungtuchen
Copy link

epic!

@hai-cea
Copy link
Member Author

hai-cea commented Jun 13, 2015

Thanks @transedward :)

hai-cea pushed a commit that referenced this pull request Jun 13, 2015
New List, ListItem, ListDivider, Avatar Components
@hai-cea hai-cea merged commit 3a0f118 into mui:master Jun 13, 2015
@cgestes
Copy link
Contributor

cgestes commented Jun 13, 2015

cool :) thanks

@cgestes
Copy link
Contributor

cgestes commented Jun 13, 2015

It's really nice.
In the doc it would be nice to have the code of one of the example at the bottom. (the ones with multiples lines etc..), cause right now only the code for the first example is given, but it does not allow to take the most out of your impl.

@hai-cea
Copy link
Member Author

hai-cea commented Jun 13, 2015

Thanks @cgestes - done with f6de0f5 :)

@hai-cea hai-cea mentioned this pull request Jun 13, 2015
@luisrudge
Copy link
Contributor

Awesome!

@oliviertassinari
Copy link
Member

👍

@freeslugs
Copy link
Contributor

@hai-cea love the new lists! quick question: are the lists sizes hardcoded? the demo is not responsive

@hai-cea
Copy link
Member Author

hai-cea commented Jun 14, 2015

@freeslugs ListItems are designed to take up the size of its parent container - so the developer should have all the control. :) Sorry about the docs site not being responsive - need to work on that.

@freeslugs
Copy link
Contributor

@hai-cea awesome - i'm planning on using the lists in my side-project - thanks again man 😄

@hai-cea hai-cea deleted the lists branch June 19, 2015 22:16
@CumpsD
Copy link
Contributor

CumpsD commented Jun 20, 2015

Awesome work!

@CumpsD
Copy link
Contributor

CumpsD commented Jun 22, 2015

Been playing around with Avatar a bit. Do you think it would be difficult to add an overlay effect as with RaisedButton to an image avatar?

@CumpsD
Copy link
Contributor

CumpsD commented Jul 4, 2015

Or a ripple when the image avatar gets clicked :)

@hai-cea
Copy link
Member Author

hai-cea commented Jul 4, 2015

@CumpsD I would suggest creating a new component called AvatarButton. Can you open an issue for this please?

@CumpsD
Copy link
Contributor

CumpsD commented Jul 4, 2015

Good idea :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: avatar This is the name of the generic UI component, not the React module! component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants