[typescript] Fix withStyles typing for class components; remove usage as TS decorator #8561
Conversation
| @@ -53,6 +53,7 @@ import Table, { | |||
| } from '../../src/Table'; | |||
| import { withStyles, StyleRulesCallback } from '../../src/styles'; | |||
| import { withResponsiveFullScreen, DialogProps } from '../../src/Dialog'; | |||
| import { WithStyles } from '../../src/styles/withStyles'; | |||
There was a problem hiding this comment.
should we add this to the exports of material-ui/styles, so people don't have multiple imports? :)
There was a problem hiding this comment.
WithStyles is already exported in styles no? 🤔
There was a problem hiding this comment.
Yes, sir ... I am going to blame this on Firday morning 😴
There was a problem hiding this comment.
I don't think withStyles is currently exported in material-ui/styles since it keeps coming back as undefined for me.
There was a problem hiding this comment.
@amyasapp these comments were about WithStyles, which is a type... but it certainly seems like withStyles is exported from material-ui/styles.
There was a problem hiding this comment.
Hmm, I'm using v0.19.4 and not v1 beta. Would that change anything? My coworkers and I grep'd for withStyles and couldn't find it anywhere in our node_modules.
There was a problem hiding this comment.
@amyasapp yeah, I don't think there's a withStyles in v0.19.4.
oliviertassinari
changed the title
…tor (mui#8561) * Fix withStyles typing for class components; remove usage as TS decorator * Remove unnecessary non-null assertion
The compromised typing of
withStylesto support using it as a TypeScript class decorator has caused a lot of confusion. This PR makes the typing fully correct, at the expense of being able to usewithStylesas a decorator. If and when TypeScript #4881 is fixed,withStylesshould automatically be usable as a decorator again, with no loss of type safety.Resolves #8447.
Breaking change