[ButtonBase] Fix missing keyboard ripple #8723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
component: button
src/ButtonBase/ButtonBase.js
Outdated
| @@ -41,6 +41,10 @@ type ProvidedProps = { | |||
|
|
|||
| export type Props = { | |||
| /** | |||
| * If `true`, the ripple will me active on mount | |||
There was a problem hiding this comment.
Missing dot at the end.
|
@oliviertassinari ah i added start() instead of pulsate() - should pulsate now :) but i have to investigate how this is working internally - i think there is still sth wrong with keyboard focus |
|
Nop, that won't make it, the pulsation state needs to be in sync with the focus state. I'm looking into it. |
| event.persist(); | ||
| const keyboardFocusCallback = this.onKeyboardFocusHandler.bind(this, event); | ||
| detectKeyboardFocus(this, this.button, keyboardFocusCallback); | ||
| // Fix for https://github.com/facebook/react/issues/7769 |
oliviertassinari
changed the title
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
|
It doesn´t working yet.. even in the demos. https://material-ui.com/demos/dialogs/ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is the fix for #8438Olivier edits:
I have changed my mind. I don't think that the pulsation display should be the default behavior for the
autoFocusproperty. It feels too opinionated. For instance, it's not how a native input behaves.I would rather see people opting-in this behavior with #3008.
Still, I have found a bug with the keyboard display of the ripple. We are good now:
Closes #8438