Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table] add Responsive table option #9238

Closed
wants to merge 9 commits into from
Closed

[Table] add Responsive table option #9238

wants to merge 9 commits into from

Conversation

Skaronator
Copy link
Contributor

Closes: #9221

@Skaronator
Copy link
Contributor Author

@oliviertassinari Mh checks doesn't run anymore? Looks like you need to update the Repo URL since it is now mui-org/material-ui instead of callemall/material-ui

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 20, 2017

@Skaronator Yeah, I will have a look at the post migration issues, so far we have

  • broken codesandbox
  • update the link in the readme
  • fix the CI

@mbrookes mbrookes added the component: table This is the name of the generic UI component, not the React module! label Nov 21, 2017
@Skaronator
Copy link
Contributor Author

Skaronator commented Nov 22, 2017

Cheks seems to work except for codecov but when going to the Website it actually says, that it passed my commit? https://codecov.io/gh/mui-org/material-ui/commits

@mbrookes
Copy link
Member

@Skaronator Yes, I think I missed a step, so checks were running, but not reporting back. Could you try again?

@Skaronator
Copy link
Contributor Author

@mbrookes Yup works now! I'll make a new PR so we don't have those dumb commits in master branch (lol).

@Skaronator Skaronator closed this Nov 22, 2017
@mbrookes
Copy link
Member

@Skaronator You can easily remove them: git rebase -i HEAD~10, and change pick to d (drop) on the unneeded ones.

We'll be squashing when merging anyway.

@mbrookes mbrookes reopened this Nov 22, 2017
@Skaronator
Copy link
Contributor Author

Skaronator commented Nov 22, 2017

Already did #9268 mh... Also the other comments are not checked by CI. Maybe you could rerun it manually but #9268.

@mbrookes mbrookes closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants