Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve composability of AppBar with IconButton, SvgIcon, FlatButton and FloatingActionButton #967

Merged
merged 4 commits into from
Jun 28, 2015
Merged

Improve composability of AppBar with IconButton, SvgIcon, FlatButton and FloatingActionButton #967

merged 4 commits into from
Jun 28, 2015

Conversation

oliviertassinari
Copy link
Member

[IconButton] pass iconStyle props to every children
[AppBar] when displaying IconButton element, set the iconStyle props
[AppBar] display flatButton with the correct style
[FloatingActionButton] accept FontIcon and SvgIcon as child

Fix #894

@oliviertassinari oliviertassinari changed the title Improve composability of AppBar with IconButton and SvgIcon Improve composability of AppBar with IconButton, SvgIcon and FlatButton Jun 27, 2015
@oliviertassinari oliviertassinari changed the title Improve composability of AppBar with IconButton, SvgIcon and FlatButton Improve composability of AppBar with IconButton, SvgIcon, FlatButton and FloatingActionButton Jun 27, 2015
@hai-cea
Copy link
Member

hai-cea commented Jun 27, 2015

@oliviertassinari Thanks for this PR. It looks great - I just had a few comments.

@oliviertassinari
Copy link
Member Author

@hai-cea done

@oliviertassinari oliviertassinari mentioned this pull request Jun 28, 2015
Closed
@hai-cea
Copy link
Member

hai-cea commented Jun 28, 2015

Thanks @oliviertassinari !

hai-cea added a commit that referenced this pull request Jun 28, 2015
@hai-cea
Merge pull request #967 from oliviertassinari/iconbutton
c7f3c88 
Improve composability of AppBar with IconButton, SvgIcon, FlatButton and FloatingActionButton
@hai-cea hai-cea merged commit c7f3c88 into mui:master Jun 28, 2015
@oliviertassinari oliviertassinari mentioned this pull request Jul 5, 2015
Closed
@oliviertassinari oliviertassinari deleted the iconbutton branch August 14, 2015 08:33
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 10, 2020
@dmtrKovalenko
Make day labels to be a Typography, closes mui#967
58582ae
@zannager zannager added the component: app bar This is the name of the generic UI component, not the React module! label Mar 14, 2023
@maniator maniator mentioned this pull request Jul 8, 2023
Open
@akashmitra akashmitra mentioned this pull request Jul 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: app bar This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FloatingActionButton] OverlayWhenHovered bug when using a FontIcon
3 participants
@oliviertassinari @hai-cea @zannager