Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add a reference to create-react-app-with-flow #9735

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

oliviertassinari
Copy link
Member

Remove some unneeded dependencies raised by @cherniavskii in #9732.

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jan 4, 2018
@oliviertassinari oliviertassinari self-assigned this Jan 4, 2018
@oliviertassinari oliviertassinari merged commit 573b657 into mui:v1-beta Jan 4, 2018
@cherniavskii
Copy link
Member

@oliviertassinari

Looks like other examples should be updated too:

  1. It's better to use jssPreset, exposed in [core] Update jss plugins dependencies #9732 instead of jss-preset-default in create-react-app-with-jss:
    https://github.com/mui-org/material-ui/blob/v1-beta/examples/create-react-app-with-jss/src/withRoot.js

  2. We can remove jss-preset-default, jss and react-jss from create-react-app-with-flow example, since those dependencies aren't used.

  3. We can remove jss and react-jss from nextjs example, since those dependencies aren't used.

I can submit a PR

@oliviertassinari oliviertassinari deleted the docs-examples branch January 5, 2018 08:16
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 5, 2018

@cherniavskii Yes, I agree. I was sold on the idea that people don't have to add an external dependency like jss-preset-default as they can get away quickly with our preset. For instance, on my project it take 5 minutes to run yarn. (running in a Docker and compiling C dependencies every time).

@oliviertassinari
Copy link
Member Author

Can you submit a new pull request? :)

@cherniavskii
Copy link
Member

@oliviertassinari sure, I'll submit it today ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants