-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SelectField] No longer rely on floatingLabelText to get correct styling #976
Conversation
@tylermichael Something still seems to be weird. Here's what I see when I remove the |
Hmm... Are you sure that you are on the correct branch? That picture is what I was seeing before I made these changes. I have pulled my branch on two separate machines, a Windows and a Mac, both showing the same thing. What browser and OS are you using? Here is what I am seeing: |
I think I see what you are doing now... Are you doing something like this?
If so, working on a fix. |
Oh, I made an other PR for the same issue, oups. #994 |
@oliviertassinari Is there any difference between yours and this one? |
@hai-cea From what I can see, I have less changes on the css. |
[SelectField] No longer rely on floatingLabelText to get correct styling
Thanks @tylermichael |
If you had a
SelectField
component without afloatingLabelText
prop, you would end up getting a messed up looking component. This fixes that.Also fixes #934.