https://tools-public.mui.com/prod/pages/1t353h04 broken since Toolpad v0.1.20

[oliviertassinari]

Context 🔦

It works in v0.1.19.

It crashes in v0.1.20 with:

Noticed this in https://www.notion.so/GitHub-community-issues-PRs-Tier-1-12a84fdf50e44595afc55343dac00fca?d=18038d4bbdbb40bc8a1ca714803aef13&pvs=4#c59aa53a2054400b98613dfb84b4cb03

Maybe mui/toolpad#1991 is the origin.

Your environment 🌎

npx @mui/envinfo

  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

[Janpot]

We started being more strict about which browser APIs can be used. I think we can whitelist Intl:

diff --git a/packages/toolpad-core/src/jsBrowserRuntime.tsx b/packages/toolpad-core/src/jsBrowserRuntime.tsx
index 6d3611553..6baae4ab3 100644
--- a/packages/toolpad-core/src/jsBrowserRuntime.tsx
+++ b/packages/toolpad-core/src/jsBrowserRuntime.tsx
@@ -20,7 +20,7 @@ function createBrowserRuntime(): JsRuntime {
       (() => {
         // See https://tc39.es/ecma262/multipage/global-object.html#sec-global-object
         const ecmaGlobals = new Set([ 'globalThis', 'Infinity', 'NaN', 'undefined', 'eval', 'isFinite', 'isNaN', 'parseFloat', 'parseInt', 'decodeURI', 'decodeURIComponent', 'encodeURI', 'encodeURIComponent', 'AggregateError', 'Array', 'ArrayBuffer', 'BigInt', 'BigInt64Array', 'BigUint64Array', 'Boolean', 'DataView', 'Date', 'Error', 'EvalError', 'FinalizationRegistry', 'Float32Array', 'Float64Array', 'Function', 'Int8Array', 'Int16Array', 'Int32Array', 'Map', 'Number', 'Object', 'Promise', 'Proxy', 'RangeError', 'ReferenceError', 'RegExp', 'Set', 'SharedArrayBuffer', 'String', 'Symbol', 'SyntaxError', 'TypeError', 'Uint8Array', 'Uint8ClampedArray', 'Uint16Array', 'Uint32Array', 'URIError', 'WeakMap', 'WeakRef', 'WeakSet', 'Atomics', 'JSON', 'Math', 'Reflect' ]);
-        const allowedDomGlobals = new Set([ 'setTimeout', 'console', 'URL', 'URLSearchParams' ])
+        const allowedDomGlobals = new Set([ 'setTimeout', 'console', 'URL', 'URLSearchParams', 'Intl' ])
 
         // NOTE: This is by no means intended to be a secure way to hide DOM globals 
         const globalThis = new Proxy(window.__SCOPE, {

[oliviertassinari]

I confirm the fix worked, thanks!