[code-infra] Shareable renovate preset #391

brijeshb42 · 2025-07-03T09:42:08Z

This config will be extended in the downstream repos using -

{
  "extends": ["github>mui/mui-public//renovate/default"]
}

See - https://docs.renovatebot.com/config-presets/#github
Companion PRs -

Janpot · 2025-07-03T18:56:20Z

I think sharing via npm package is deprecated:

Warning
We deprecated npm-based presets. We plan to drop the npm-based presets feature in a future major release of Renovate.

I was thinking, maybe we can add a top-level renovate folder that holds all presets?

brijeshb42 · 2025-07-04T03:12:11Z

We deprecated npm-based presets

I saw this as well. So we can use the http url format (raw.githubusercontent.com/<path>) in the extends field of the individual repos.

Janpot · 2025-07-04T05:42:27Z

I was thinking github>mui/mui-public//renovate/default should find a preset under /renovate/default.json if I understand their docs correctly.

renovate/default.json

michaldudak · 2025-07-07T06:39:59Z

renovate/default.json

+  "prConcurrentLimit": 30,
+  "prHourlyLimit": 0,
+  "rangeStrategy": "bump",
+  "schedule": "on sunday before 6:00am",


Having all projects build their PRs roughly at the same time can put more stress on the CI and possibly lead to timeouts. What do you think about having each project define its schedule?

Its what there was in all the repos. Downstream repos can still override this value if required. When not provided, this will be the default.

Probably overkill, but if we want to control this value from the central mui-public repo we could create a schedule-<repo> preset for each of the repositories.

renovate/default.json

michaldudak · 2025-07-07T07:42:15Z

renovate/default.json

+      "matchPackageNames": ["vite", "@vitejs/**", "/vitest/", "esbuild", "^vitest$", "^@vitest/"]
+    },
+    {
+      "automerge": true,


This doesn't work as well as it could as all PRs require explicit approval. I added it in Base UI, but there's not much value TBH

On X we have a top rule to automerge any non-overridden dev dependency updates.
It works well-ish, especially when CI is stable. 👌
https://github.com/mui/mui-x/blob/37a677b4d4137c39c0415517144990dede8aadee/renovate.json#L12-L16

LukasTy · 2025-07-07T08:13:48Z

renovate/default.json

+      "groupName": "Infra packages",
+      "matchPackageNames": ["@mui/internal-*", "@mui/docs"],


I wonder how this will combine with other wildcard patterns.
Do you know how it will work if we inherit this config and have a @mui/* group in the specific package file?

Link - docs.renovatebot.com/configuration-options#packagerules

If multiple rules match a dependency, configurations from matching rules will be merged together. The order of rules matters, because later rules may override configuration options from earlier ones, if they both specify the same option.

So in this particular case, followTag will also have to be added in your @mui/* group so that it overrides the value from the base config.

LukasTy · 2025-07-07T08:15:59Z

renovate/default.json

+      "matchPackageNames": ["@types/node", "node", "cimg/node", "actions/setup-node"],
+      "enabled": false


I'm having second thoughts about this.
IMHO, @types/node should be updated within a specified major.
Same for cimg/node and actions/setup-node. Especially the latter, since it does not directly relate to the Node package version. 🤔

Posted reply to the wrong comment. It's for your previous comment.

I recently proposed to change this in core repo. not sure how well it will work though. not all these environments necessarily support the same minor versions.

I agree that actions/setup-node should not be in the same group because its version can be updated independently of others. So I have removed it from the group in this PR.

not all these environments necessarily support the same minor versions

It should be fine as long as we specify only a major version in allowedVersions intead of pinning to a specific node version. WDYT ?

renovate should configure the node version of actions/setup-node, I think it belongs in this group. the action itself can be latest version. we may have to specify which package manager we target exactly.

edit: https://docs.renovatebot.com/modules/manager/github-actions/#withversion-support-for-built-in-actions

Should it?
I think we only specify the major and AFAIK, we manually decide when we want to bump the major. 🤔

not all these environments necessarily support the same minor versions

It should be fine as long as we specify only a major version in allowedVersions intead of pinning to a specific node version. WDYT ?

Yes, renovate group could specify that it allows "<23".

Should it?

if I interprete their docs correctly, yes. that's why I made that change, to test whether/how that works. their docs tend to be a bit cryptic sometimes

@Janpot It is enabled: false for this group. So will it still bump the version os actions/setup-node action while not bumping node-version param. I don't have a lot of clarity based on the docs.

Yes, I want to enable it again so we update node versions everywhere we use node and sync the major version through renovate. the group:nodeJs seems to be able to do what we want. Perhaps we should use it, or start from it? I think what could missing on our side is specifying the datasource. I suppose by narrowing it to docker and node-version it excludes updating the github action?

e.g. The following could work:

{ "extends": ["group:node"], "packageRules": [ { "matchPackageNames": ["node"], "matchDatasources": ["node", "docker"], "allowedVersions": "22.x", "versionConstraint": "22.x" } ] }

michaldudak · 2025-07-07T08:16:38Z

Make sure to run config validator before merging this.

mui/mui-x#18794

Janpot · 2025-07-14T09:53:55Z

renovate/default.json

+    {
+      "groupName": "core-js",
+      "matchPackageNames": ["core-js"],
+      "allowedVersions": "< 2.0.0"


Aside, do you know why we do this? I think we should document this somewhere and figure out if it's still relevant.

I personally don't know. I saw this in all the repo, so copied here. Maybe @oliviertassinari or @mnajdova do ?

No idea, it's here since the beginning of time :D mui/material-ui#27003

Janpot · 2025-07-14T09:55:32Z

renovate/default.json

+        "react-is",
+        "@types/react",
+        "@types/react-dom",
+        "@types/react-is"


I believe we also use use-sync-external-store in some places. It's also maintained by the react team.

Janpot · 2025-07-14T09:56:21Z

renovate/default.json

+    },
+    {
+      "groupName": "Playwright",
+      "matchPackageNames": ["@playwright/test", "mcr.microsoft.com/playwright"]


I know in some places we only use @playwright/test but perhaps we should widen to include @playwright/* and playwright?

I checked all repos and found that we only explicitly depend on @playwright/test and no other playwright package. But agree that it wouldn't hurt

Janpot · 2025-07-14T10:53:11Z

renovate/default.json

      "groupName": "node",
+      "matchDatasources": ["docker", "node-version"],
      "matchPackageNames": ["@types/node", "node", "cimg/node", "actions/setup-node"],
      "enabled": false


I believe we could mandate a major instead of disabling?

Suggested change

"enabled": false

"allowedVersions": "22"

Before that, we'll have to make sure all repos actually are using this version

If not we can also create presets for each node version we want to support, so on repo side they can do

{ "extends": ["github>mui/mui-public//renovate/default", "github>mui/mui-public//renovate/node-20"] }

Janpot

This seems mostly fine, I'd like to figure out if we can steer all node versioning from the renovate config if possible. Also ok for me if you want to look into it in separate PR.

brijeshb42 · 2025-07-14T15:57:20Z

Yeah. I'll tackle the node versioning in a separate PR. Lets first bring all repos to node 22.

brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Jul 3, 2025

brijeshb42 force-pushed the renovate-config branch from d25d8ea to cdc2d84 Compare July 3, 2025 09:50

brijeshb42 force-pushed the renovate-config branch from cdc2d84 to 0db2481 Compare July 4, 2025 03:13

brijeshb42 marked this pull request as draft July 4, 2025 03:14

brijeshb42 force-pushed the renovate-config branch 4 times, most recently from c891fab to 3f44180 Compare July 4, 2025 06:34

brijeshb42 requested a review from a team July 4, 2025 06:36

brijeshb42 marked this pull request as ready for review July 4, 2025 06:36

michaldudak reviewed Jul 4, 2025

View reviewed changes

renovate/default.json Outdated Show resolved Hide resolved

brijeshb42 force-pushed the renovate-config branch from 6b0863d to 1778d65 Compare July 4, 2025 11:30

brijeshb42 requested a review from a team July 7, 2025 05:57

michaldudak reviewed Jul 7, 2025

View reviewed changes

brijeshb42 force-pushed the renovate-config branch from 4e97ab5 to 4a971db Compare July 7, 2025 07:27

michaldudak reviewed Jul 7, 2025

View reviewed changes

brijeshb42 force-pushed the renovate-config branch from 4a971db to a2f7d1a Compare July 7, 2025 07:44

LukasTy reviewed Jul 7, 2025

View reviewed changes

brijeshb42 force-pushed the renovate-config branch from 71271fd to 9cec825 Compare July 9, 2025 11:08

Janpot mentioned this pull request Jul 13, 2025

[code-infra] Fix renovate PR titles mui/mui-x#18794

Closed

oliviertassinari added the type: new feature Expand the scope of the product to solve a new problem. label Jul 13, 2025

Brijesh Bittu added 5 commits July 14, 2025 11:11

[code-infra] Shareable renovate preset

935dcf1

Move some shareable config from x

7ef82a4

Moved some config from base-ui

620eb8e

Review fix

23a5d0e

Remove actions/setup-node from node group

94e5c73

brijeshb42 force-pushed the renovate-config branch from 9cec825 to a23ca77 Compare July 14, 2025 05:44

Disable semantic commit

30a1bd3

mui/mui-x#18794

brijeshb42 force-pushed the renovate-config branch from a23ca77 to 30a1bd3 Compare July 14, 2025 05:44

brijeshb42 requested a review from Janpot July 14, 2025 06:24

Janpot reviewed Jul 14, 2025

View reviewed changes

More review fixes

2508ae6

Janpot reviewed Jul 14, 2025

View reviewed changes

Janpot approved these changes Jul 14, 2025

View reviewed changes

brijeshb42 merged commit 6c50939 into master Jul 14, 2025
8 checks passed

brijeshb42 deleted the renovate-config branch July 14, 2025 15:57

brijeshb42 mentioned this pull request Jul 15, 2025

[code-infra] Extend renovate preset from infra repo mui/mui-x#18683

Merged

1 task

Janpot mentioned this pull request Jul 17, 2025

[code-infra] Remove transform-runtime from next/babel mui/material-ui#46552

Merged

		"groupName": "Infra packages",
		"matchPackageNames": ["@mui/internal-*", "@mui/docs"],

		"matchPackageNames": ["@types/node", "node", "cimg/node", "actions/setup-node"],
		"enabled": false

[code-infra] Shareable renovate preset #391

[code-infra] Shareable renovate preset #391

Uh oh!

Conversation

brijeshb42 commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Janpot commented Jul 3, 2025

Uh oh!

brijeshb42 commented Jul 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Janpot commented Jul 4, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brijeshb42 Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Janpot Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaldudak commented Jul 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

brijeshb42 commented Jul 3, 2025 •

edited

Loading

brijeshb42 commented Jul 4, 2025 •

edited

Loading

brijeshb42 Jul 7, 2025 •

edited

Loading

Janpot Jul 7, 2025 •

edited

Loading

brijeshb42 Jul 8, 2025 •

edited

Loading

Janpot Jul 8, 2025 •

edited

Loading

Janpot Jul 8, 2025 •

edited

Loading

Janpot Jul 14, 2025 •

edited

Loading

Janpot Jul 14, 2025 •

edited

Loading

Janpot Jul 14, 2025 •

edited

Loading