-
Notifications
You must be signed in to change notification settings - Fork 29
[code-infra] Migrate away from using airbnb config #556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59769e1 to
e3cbf86
Compare
Bundle size report
|
e3cbf86 to
260bc16
Compare
260bc16 to
580f4cc
Compare
580f4cc to
bfbfc3b
Compare
bfbfc3b to
2b09dc0
Compare
2b09dc0 to
60b488f
Compare
60b488f to
30f1abe
Compare
30f1abe to
7c05b31
Compare
7c05b31 to
55cdd5d
Compare
55cdd5d to
ffa5e87
Compare
ffa5e87 to
d29daf8
Compare
d29daf8 to
6652c52
Compare
.gitignore
Outdated
| *.tsbuildinfo | ||
|
|
||
| size-snapshot.json | ||
| .generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Shouldn't prettier catch these missing newlines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier is not formatting this file from what I can see.
Janpot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I have nothing to add except for that we should catch those newlines. I have reviewed all three individual PRS and left my comments
6652c52 to
54ed501
Compare
86eb11c to
f8ed962
Compare
f8ed962 to
39ff3bb
Compare
|
Ok. Merging this then. |
This now uses recommended configs from the individual plugins plus some extra rules from airbnb-config that were not part of the recommended configs.
What was migrated:
Rules to discuss -
class-methods-use-this- Turned it off. I figured we always end up disabling it inline regardless.@typescript-eslint/no-non-null-asserted-optional-chain- Turned it on. Syntactically doesn't make sense to do something like thisoptional?.property!where the object could be null but we are making the property access as non-null.@typescript-eslint/ban-ts-comment- Turned it on. Instead of just writing@ts-ignore, write@ts-expect-error reason-for-turning-ts-off.Repo PRs -
Fixes #483