Skip to content

Conversation

@brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Aug 18, 2025

This now uses recommended configs from the individual plugins plus some extra rules from airbnb-config that were not part of the recommended configs.

What was migrated:

  • From 326 Airbnb rules to 127 individual plugin recommended rules + 37+ critical Airbnb rules
  • All critical security, best practices, ES6+, and import rules from Airbnb
  • TypeScript-specific rule handling
  • Import settings from Airbnb base configuration
  • Proper flat config structure

Rules to discuss -

  1. class-methods-use-this - Turned it off. I figured we always end up disabling it inline regardless.
  2. @typescript-eslint/no-non-null-asserted-optional-chain - Turned it on. Syntactically doesn't make sense to do something like this optional?.property! where the object could be null but we are making the property access as non-null.
  3. @typescript-eslint/ban-ts-comment - Turned it on. Instead of just writing @ts-ignore, write @ts-expect-error reason-for-turning-ts-off.

Repo PRs -

  1. [infra] Migrate away from airbnb's eslint config material-ui#46794
  2. [infra] Migrate to use eslint without airbnb config mui-x#19269
  3. [code-infra] Migrate to eslint without airbnb dependency base-ui#2547
  4. https://github.com/mui/joy-ui/pull/235

Fixes #483

@brijeshb42 brijeshb42 added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Aug 18, 2025
@oliviertassinari oliviertassinari temporarily deployed to airbnb-migrate-new - mui-tools-public PR #556 August 18, 2025 14:41 — with Render Destroyed
@mui-bot
Copy link

mui-bot commented Aug 18, 2025

Bundle size report

Bundle Parsed size Gzip size
@base-ui-components/react 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 39ff3bb

@oliviertassinari oliviertassinari temporarily deployed to airbnb-migrate-new - mui-tools-public PR #556 August 21, 2025 04:46 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to airbnb-migrate-new - mui-tools-public PR #556 August 21, 2025 04:50 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to airbnb-migrate-new - mui-tools-public PR #556 August 21, 2025 04:53 — with Render Destroyed
@brijeshb42 brijeshb42 marked this pull request as ready for review August 21, 2025 06:52
@brijeshb42 brijeshb42 changed the title [wip][infra] Migrate away from using airbnb config [infra] Migrate away from using airbnb config Aug 21, 2025
.gitignore Outdated
*.tsbuildinfo

size-snapshot.json
.generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Shouldn't prettier catch these missing newlines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier is not formatting this file from what I can see.

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I have nothing to add except for that we should catch those newlines. I have reviewed all three individual PRS and left my comments

@oliviertassinari oliviertassinari temporarily deployed to airbnb-migrate-new - mui-tools-public PR #556 August 21, 2025 13:31 — with Render Destroyed
@brijeshb42 brijeshb42 force-pushed the airbnb-migrate-new branch 2 times, most recently from 86eb11c to f8ed962 Compare August 21, 2025 13:58
@brijeshb42
Copy link
Contributor Author

Ok. Merging this then.

@brijeshb42 brijeshb42 merged commit 7364567 into master Aug 21, 2025
12 checks passed
@brijeshb42 brijeshb42 deleted the airbnb-migrate-new branch August 21, 2025 14:00
@oliviertassinari oliviertassinari changed the title [infra] Migrate away from using airbnb config [code-infra] Migrate away from using airbnb config Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code-infra] Move away from eslint config airbnb

5 participants