[data-grid] Remove minFirstColumn from GetHeadersParams interface (…

…#14450) Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
mui · Sep 18, 2024 · edc76e0 · edc76e0
1 parent 4c73098
commit edc76e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/packages/x-data-grid-pro/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx b/packages/x-data-grid-pro/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx
@@ -166,19 +166,16 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
           getColumnFilters({
             position: GridPinnedColumnPosition.LEFT,
             renderContext: leftRenderContext,
-            minFirstColumn: leftRenderContext.firstColumnIndex,
             maxLastColumn: leftRenderContext.lastColumnIndex,
           })}
         {getColumnFilters({
           renderContext,
-          minFirstColumn: pinnedColumns.left.length,
           maxLastColumn: visibleColumns.length - pinnedColumns.right.length,
         })}
         {rightRenderContext &&
           getColumnFilters({
             position: GridPinnedColumnPosition.RIGHT,
             renderContext: rightRenderContext,
-            minFirstColumn: rightRenderContext.firstColumnIndex,
             maxLastColumn: rightRenderContext.lastColumnIndex,
           })}
       </GridColumnHeaderRow>

diff --git a/packages/x-data-grid/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx b/packages/x-data-grid/src/hooks/features/columnHeaders/useGridColumnHeaders.tsx
@@ -65,7 +65,6 @@ export interface UseGridColumnHeadersProps {
 export interface GetHeadersParams {
   position?: GridPinnedColumnPosition;
   renderContext?: GridColumnsRenderContext;
-  minFirstColumn?: number;
   maxLastColumn?: number;
 }
 
@@ -158,11 +157,8 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
 
   // Helper for computation common between getColumnHeaders and getColumnGroupHeaders
   const getColumnsToRender = (params?: GetHeadersParams) => {
-    const {
-      renderContext: currentContext = renderContext,
-      // TODO: `minFirstColumn` is not used anymore, could be refactored out.
-      maxLastColumn = visibleColumns.length,
-    } = params || {};
+    const { renderContext: currentContext = renderContext, maxLastColumn = visibleColumns.length } =
+      params || {};
 
     const firstColumnToRender = currentContext.firstColumnIndex;
     const lastColumnToRender = !hasVirtualization ? maxLastColumn : currentContext.lastColumnIndex;
@@ -334,22 +330,19 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
             {
               position: GridPinnedColumnPosition.LEFT,
               renderContext: leftRenderContext,
-              minFirstColumn: leftRenderContext.firstColumnIndex,
               maxLastColumn: leftRenderContext.lastColumnIndex,
             },
             { disableReorder: true },
           )}
         {getColumnHeaders({
           renderContext,
-          minFirstColumn: pinnedColumns.left.length,
           maxLastColumn: visibleColumns.length - pinnedColumns.right.length,
         })}
         {rightRenderContext &&
           getColumnHeaders(
             {
               position: GridPinnedColumnPosition.RIGHT,
               renderContext: rightRenderContext,
-              minFirstColumn: rightRenderContext.firstColumnIndex,
               maxLastColumn: rightRenderContext.lastColumnIndex,
             },
             {
@@ -499,7 +492,6 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
               params: {
                 position: GridPinnedColumnPosition.LEFT,
                 renderContext: leftRenderContext,
-                minFirstColumn: leftRenderContext.firstColumnIndex,
                 maxLastColumn: leftRenderContext.lastColumnIndex,
               },
             })}
@@ -510,7 +502,6 @@ export const useGridColumnHeaders = (props: UseGridColumnHeadersProps) => {
               params: {
                 position: GridPinnedColumnPosition.RIGHT,
                 renderContext: rightRenderContext,
-                minFirstColumn: rightRenderContext.firstColumnIndex,
                 maxLastColumn: rightRenderContext.lastColumnIndex,
               },
             })}