Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Simplify --width property indirection with width #14779

Open
oliviertassinari opened this issue Sep 30, 2024 · 0 comments
Open

[data grid] Simplify --width property indirection with width #14779

oliviertassinari opened this issue Sep 30, 2024 · 0 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes feature: Rendering layout Related to the data grid Rendering engine priority: low To delay as much as possible

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 30, 2024

I'm opening this issue as a potential low priority opportunity to improve the row width management.

We use a --width CSS variables indirection to set the width of the rows https://github.com/search?q=repo%3Amui%2Fmui-x+--width+path%3A%2F%5Epackages%5C%2Fx-data-grid%2F&type=code but there doesn't seem to be a good reason to do such.

Instead, it seems that modifying the width style properly directly would be:

  • simpler, no indication
  • a bit more performant

This was discovered in #14776. Now, this doesn't seem to be a major concern, more of a low-hanging fruit. I doubt it will make column resizing much more performant, nor that there is a major performance win to gain so a low priority.

Search keywords:

@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! status: waiting for maintainer These issues haven't been looked at yet by a maintainer priority: low To delay as much as possible labels Sep 30, 2024
@michelengelen michelengelen added feature: Rendering layout Related to the data grid Rendering engine and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 1, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes feature: Rendering layout Related to the data grid Rendering engine priority: low To delay as much as possible
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

2 participants