Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Replace minWidth, maxWidth with width #14776

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[core] Replace minWidth, maxWidth with width #14776

merged 1 commit into from
Sep 30, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Sep 30, 2024 •
edited
Loading

This is the result of a merge conflict. I refactored this in #14448 but #14124 wasn't merged yet. A quick-win.

@oliviertassinari
[core] Replace minWidth, maxWidth with width
de9002b 
This is the result of a merge conflict. I refactored this in mui#14448
but this PR wasn't merged yet.
@oliviertassinari oliviertassinari added core Infrastructure work going on behind the scenes component: data grid This is the name of the generic UI component, not the React module! labels Sep 30, 2024
@oliviertassinari oliviertassinari mentioned this pull request Sep 30, 2024
Merged
20 tasks
@mui-bot
Copy link

mui-bot commented Sep 30, 2024

Deploy preview: https://deploy-preview-14776--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against de9002b

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Sep 30, 2024 •
edited
Loading

As a side thought, the use of a CSS variable for width feels like something that we should remove.
CSS variables are inherited, so updates are slower to resolve for browsers, e.g. https://emilkowal.ski/ui/building-a-drawer-component#drag-gesture and we never reuse the --width value anyway.

@oliviertassinari oliviertassinari merged commit 51d0b3a into mui:master Sep 30, 2024
23 of 24 checks passed
@oliviertassinari oliviertassinari deleted the simplification branch September 30, 2024 16:28
@oliviertassinari oliviertassinari mentioned this pull request Sep 30, 2024
Open
This was referenced Nov 1, 2024
Open
Open
Open
@DMPatod DMPatod mentioned this pull request Nov 2, 2024
Open
@mbreadmachine mbreadmachine mentioned this pull request Nov 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliviertassinari @mui-bot @romgrk @MBilalShafi