setState leak after unmount

[oliviertassinari]

@dtassone The issue was caught in the CI (Karma), something is calling setState after the component is unmounted. It leaks.

---

@eps1lon this makes me think that we might have an improvement opportunity in the CI, shouldn't we fail if a component call console.warn or console.error during the tests? I believe it works when we run the tests in JSDOM, but not with Karma. I don't know why yet. The data grid might be an exception as all JSDOM tests are skipped (require layout).

[oliviertassinari]

@eps1lon Actually, I think that it's a regression from mui/material-ui#21581.

1. test/utils/init.js runs for karma and jsdom
2. test/utils/setup.js runs for jsdom only

We moved the console throw logic from 1. to 2. hence left karma without coverage

[eps1lon]

We moved the console throw logic from 1. to 2. hence left karma without coverage

If karma had no warn/error logic then every test using toWarnDev/toErrorDev would throw.

Why would code from the main repo affect code in this repo?

[eps1lon]

Yeah so I had to investigate this more since you didn't communicate what you discovered: It's about unexpected calls not covering console warn/error, right? We should move this around, yes. PRs welcome.

[oliviertassinari]

@eps1lon I will open a PR :)

[oliviertassinari]

Fixed in mui/material-ui#22075