Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Scroll performance regression in v8 vs. v7 #15957

Closed
lauri865 opened this issue Dec 20, 2024 · 4 comments · Fixed by #15959
Closed

[data grid] Scroll performance regression in v8 vs. v7 #15957

lauri865 opened this issue Dec 20, 2024 · 4 comments · Fixed by #15959
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse

Comments

@lauri865
Copy link
Contributor

lauri865 commented Dec 20, 2024

Steps to reproduce

Scrubbing scrollbar has become much slower to update for some reason.

v7 docs:

v7.mp4

v8 docs:

v8.mp4

Not sure what's causing it at this point. FWIW, we're not witnessing it with v7 in React 19.

Introduced in v8.0.0-alpha.5 it seems: v8.0.0-alpha.4...v8.0.0-alpha.5.

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Search keywords: scroll performance

@lauri865 lauri865 added bug 🐛 Something doesn't work status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Dec 20, 2024
@lauri865
Copy link
Contributor Author

Actually seems to have started from here: #15144
Strangely, I cannot reproduce this in dev, only when I build for production.

💡 Learned something new about Github that I've been missing, to check pull requests in the order of merging is actually possible:
https://github.com/mui/mui-x/pulse#merged-pull-requests

@lauri865
Copy link
Contributor Author

lauri865 commented Dec 20, 2024

Seems to be Next15 issue. Can't reproduce with vanilla react app in either React 18 or 19, resolves when downgrading to Next@14.

@michelengelen michelengelen added the component: data grid This is the name of the generic UI component, not the React module! label Dec 20, 2024
@lauri865
Copy link
Contributor Author

It seems that the issue is that the docs is built with production profiler, which adds overhead. For whatever reason the overhead is higher in Next15, but there was always some overhead.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@lauri865 How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 20, 2024
@oliviertassinari oliviertassinari added the regression A bug, but worse label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants