[docs] Remove production profiler from docs build #15959
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-15959--material-ui-x.netlify.app/ |
|
Before: After: Drag the scrollbar up/down and verify that there's no flash of content anymore. It might be desirable to add the profiler to preview builds though, but this is to display the root cause of the issue. Could potentially affect #15681 as well. |
romgrk
approved these changes
Dec 20, 2024
oliviertassinari
changed the title
| "build": "rimraf ./export && cross-env NODE_ENV=production next build --profile && pnpm build-sw", | ||
| "build": "rimraf ./export && cross-env NODE_ENV=production next build && pnpm build-sw", |
There was a problem hiding this comment.
@eps1lon initially added this flag in mui/material-ui#21975.
I'm making the connection as it seems that this started with upgrading Next.js 14.2.20 -> 15.1.1 #15144.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15957 – production profiler adds overhead to rendering, which hurts performance. For whatever reason the performance impact is higher in next15, impacting scroll performance visibly.