[DataGrid] Refactor: move progress components to leaf import #15914
Conversation
romgrk
added
the
component: data grid
|
Deploy preview: https://deploy-preview-15914--material-ui-x.netlify.app/ |
| @@ -67,7 +66,7 @@ function GridGroupingCriteriaCellIcon(props: GridGroupingCriteriaCellIconProps) | |||
| if (isDataLoading) { | |||
| return ( | |||
| <div className={classes.loadingContainer}> | |||
| <CircularProgress size="1rem" color="inherit" /> | |||
| <rootProps.slots.baseCircularProgress size="1rem" color="inherit" /> | |||
There was a problem hiding this comment.
If packages/x-data-grid-premium/src/components/GridDataSourceGroupingCriteriaCell.tsx will be unstyled, this should be, no?
| <rootProps.slots.baseCircularProgress size="1rem" color="inherit" /> | |
| <rootProps.slots.baseCircularProgress |
There was a problem hiding this comment.
Actually, I wonder if the unstyled slot shouldn't also include <div className={classes.loadingContainer}> in a slot like this? It doesn't feel clear that this DOM CSS should be part of the unstyled grid CSS file. A developer might also want to add my own div / tailwind class name on this DOM.
There was a problem hiding this comment.
If packages/x-data-grid-premium/src/components/GridDataSourceGroupingCriteriaCell.tsx will be unstyled, this should be, no?
Hard to say, I don't think there's a good answer to that. We still want to fine-tune components, but at the same time we want other design systems to be able to control anything from the outside, and those objectives are somewhat in conflict. For now I've mostly used material-ui API and left thing as-is (unless I saw a blocker for other design systems). I think I'd keep with the current refactoring approach just to get us to a point where we can set up the grid with mantine or shadcn, and then if we need to rework things a bit to allow more external control we can take that decision from there.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Kenan Yusuf <kenan.m.yusuf@gmail.com> Signed-off-by: Rom Grk <romgrk@users.noreply.github.com>
…into refactor-agnostic-progress
Part of the design-system agnostic work.
Move
CircularProgressandLinearProgressto leaf import.