-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate requirement for tslib as a dependency #47
Comments
Yes, in pickers we followed up on the usage of Babel for pickers compilation. I am not sure about building process in material-ui-x, but we are using rollup + Babel plugin which works just perfectly. Tslib is actually Babel runtime helpers, but for native ts compiler. I could contribute on making pretty same build process. |
I'm linking mui/material-ui#18447 from @eps1lon to the discussion, I think that it happens to be in the same space. |
The grid is currently only compiled with Otherwise I don't understand what the issue is. |
@eps1lon From what I understand, including babel/runtime and tslib in the bundle, leads to a duplication of the same helpers in the bundle. Does it increase the bundle size to a point we should care? |
You opened the issue. I would've expected that you identified an issue. If you need to transpile with I never used |
@eps1lon Thanks, I think that it will be interesting to follow what happens with mui/material-ui#18447, ideally, expose the same options here. |
This is a follow-up on a conversation we have started in #44 (comment). The
tslib
dependency was added in order to make codesandbox runs successfully. It's unclear if the requirement is coming from codesandbox itself or from a misconfiguration of the building pipeline.It's also to be noted that we use babel-runtime on
@material-ui/core
which might duplicate in the bundle for our users.@dmtrKovalenko Considering we have a similar building stack on the pickers, do you have any idea of what could be wrong? :)
I have added the "Post MVP" milestone as we can/should delay the resolution to later.
The text was updated successfully, but these errors were encountered: