add doc structure and example #44

dtassone · 2020-07-01T17:13:03Z

No description provided.

packages/grid/x-grid/src/grid.tsx

packages/storybook/src/docs/api.stories.mdx

packages/storybook/src/docs/demos/columns.demo.tsx

packages/storybook/src/docs/quick-start.stories.mdx

oliviertassinari · 2020-07-02T16:08:13Z

A thought, considering we will only document the components at http://material-ui.com/components/data-grid/, shouldn't we rebase this pull request to https://github.com/mui-org/material-ui?

packages/storybook/src/docs/columns.stories.mdx

oliviertassinari · 2020-07-02T16:16:42Z

I'm adding @mbrookes, I think that he can help with the wording of the documentation.

packages/storybook/src/docs/demos/columns.demo.tsx

oliviertassinari · 2020-07-02T16:41:38Z

No configuration was found in your project. Please refer to https://circleci.com/docs/2.0/ to get started with your configuration.

We will need to rebase to get the CI running (that will tell to run prettier to format the markdown)

packages/storybook/src/docs/columns.stories.mdx

…css fixes

packages/storybook/src/docs/columns.stories.mdx

mbrookes · 2020-07-05T13:47:47Z

packages/storybook/src/docs/columns.stories.mdx

+```
+In the code above we define a column with some of the basic attributes.
+- `field` is a mandatory field and is used to identify the corresponding value on rows. It's similar to an id, but has to be a string.
+- `headerName` is the title visible in the grid column header. If not set, `field` will be used in the header.


Suggested change

- `headerName` is the title visible in the grid column header. If not set, `field` will be used in the header.

- `headerName` is the title visible in the grid column header. If not set, `field` will be used in the header.

If it's a title, should it be headerTitle instead?

Maybe or just Title (remind me of tooltip title) ?
I put the same prop as AgGrid to be backward compatible, and easily try MUI grid where agGrid is already implemented 🤔
Not sure how realisable that will stand...

packages/storybook/src/docs/columns.stories.mdx

packages/storybook/src/docs/quick-start.stories.mdx

packages/storybook/src/docs/sorting.stories.mdx

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Rewording Co-authored-by: Matt <github@nospam.33m.co>

Co-authored-by: Matt <github@nospam.33m.co>

packages/demo-app/src/app/app-bar.tsx

oliviertassinari · 2020-07-06T15:51:53Z

A thought, to make debugging the code sandbox issue easier, it could be simpler to jump right now in https://codesandbox.io/docs/ci. It could allow you to test the changes with a faster feedback loop

packages/grid/x-grid-modules/src/components/row-cells.tsx

packages/grid/x-grid/package.json

dtassone · 2020-07-07T11:30:10Z

A thought, considering we will only document the components at http://material-ui.com/components/data-grid/, shouldn't we rebase this pull request to https://github.com/mui-org/material-ui?

We will do it at a later stage if necessary.

dtassone added 3 commits July 1, 2020 19:10

added doc structure and example

b2e83a6

replace xgrid with grid as not published yet

fdec9a5

WIP working on columns mdx

d31d703

oliviertassinari reviewed Jul 2, 2020

View reviewed changes

packages/storybook/src/docs/quick-start.stories.mdx Show resolved Hide resolved

oliviertassinari reviewed Jul 2, 2020

View reviewed changes

packages/storybook/src/docs/columns.stories.mdx Outdated Show resolved Hide resolved

oliviertassinari reviewed Jul 2, 2020

View reviewed changes

packages/storybook/src/docs/demos/columns.demo.tsx Outdated Show resolved Hide resolved

dtassone added 2 commits July 2, 2020 18:21

add columns doc and demos

138e920

fix column demo doc

cb5305c

fix ts code markdown

30e36eb

oliviertassinari reviewed Jul 3, 2020

View reviewed changes

packages/storybook/src/docs/columns.stories.mdx Outdated Show resolved Hide resolved

dtassone added 3 commits July 3, 2020 19:11

add autoheight, rename components Grid to XGrid, add classname prop, …

e5f7e0f

…css fixes

fix grid-root classname, fix import React

3b81c04

v0.1.43

facaad2

mbrookes requested changes Jul 5, 2020

View reviewed changes

dtassone and others added 12 commits July 6, 2020 13:42

Update packages/storybook/src/docs/columns.stories.mdx

8988297

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update packages/storybook/src/docs/columns.stories.mdx

0481c63

Rewording Co-authored-by: Matt <github@nospam.33m.co>

Rewording doc

e2e4f3c

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/columns.stories.mdx

5454c09

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/quick-start.stories.mdx

3c451c4

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/quick-start.stories.mdx

6679fc0

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/sorting.stories.mdx

229bcee

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/columns.stories.mdx

92c4fb7

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/quick-start.stories.mdx

f7fe535

Co-authored-by: Matt <github@nospam.33m.co>

Update packages/storybook/src/docs/quick-start.stories.mdx

15b3953

Co-authored-by: Matt <github@nospam.33m.co>

Rewording: Apply suggestions from code review

18820a2

Co-authored-by: Matt <github@nospam.33m.co>

Added 3rd level titles

94cc8a5

oliviertassinari reviewed Jul 6, 2020

View reviewed changes

packages/demo-app/src/app/app-bar.tsx Outdated Show resolved Hide resolved

dtassone added 7 commits July 6, 2020 18:09

remove terser

8c63b1c

v0.1.45

5fa86c9

refactor rowcells to avoid nested react

e6ca144

v0.1.46

80af7fb

better refactor of rowcells to fix codesandbox

efe6219

upgrade dependencies

e7e5338

v0.1.47

57078be

dtassone commented Jul 6, 2020

View reviewed changes

packages/grid/x-grid-modules/src/components/row-cells.tsx Show resolved Hide resolved

dtassone added 6 commits July 6, 2020 19:09

add tslib devdep

83dceac

v0.1.48

0f2063d

upgrade dependencies

1182807

v0.1.49

402d521

move tslib in dependencies :(

e7cb9e3

v0.1.50

1d82dbd

oliviertassinari reviewed Jul 6, 2020

View reviewed changes

packages/grid/x-grid/package.json Show resolved Hide resolved

dtassone added 3 commits July 7, 2020 12:54

split and simplify demos

0d296dd

Merge branch 'master' into mdxDoc

917b57e

yarn and prettier

b372f5e

dtassone closed this Jul 7, 2020

dtassone reopened this Jul 7, 2020

dtassone merged commit 071759e into master Jul 7, 2020

dtassone deleted the mdxDoc branch July 7, 2020 11:31

oliviertassinari mentioned this pull request Jul 7, 2020

Re-evaluate requirement for tslib as a dependency #47

Closed

oliviertassinari mentioned this pull request Jan 10, 2021

Remove tslib dependency from packages #832

Merged

Edelf mentioned this pull request May 26, 2022

[data grid] setEditCellValue on a editable: false cell #5029

Closed

2 tasks

oliviertassinari added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jan 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add doc structure and example #44

add doc structure and example #44

dtassone commented Jul 1, 2020

oliviertassinari commented Jul 2, 2020 •

edited

Loading

oliviertassinari commented Jul 2, 2020 •

edited

Loading

oliviertassinari commented Jul 2, 2020 •

edited

Loading

mbrookes Jul 5, 2020

dtassone Jul 6, 2020

oliviertassinari commented Jul 6, 2020 •

edited

Loading

dtassone commented Jul 7, 2020

	- `headerName` is the title visible in the grid column header. If not set, `field` will be used in the header.
	- `headerName` is the title visible in the grid column header. If not set, `field` will be used in the header.

add doc structure and example #44

add doc structure and example #44

Conversation

dtassone commented Jul 1, 2020

oliviertassinari commented Jul 2, 2020 • edited Loading

oliviertassinari commented Jul 2, 2020 • edited Loading

oliviertassinari commented Jul 2, 2020 • edited Loading

mbrookes Jul 5, 2020

Choose a reason for hiding this comment

dtassone Jul 6, 2020

Choose a reason for hiding this comment

oliviertassinari commented Jul 6, 2020 • edited Loading

dtassone commented Jul 7, 2020

oliviertassinari commented Jul 2, 2020 •

edited

Loading

oliviertassinari commented Jul 2, 2020 •

edited

Loading

oliviertassinari commented Jul 2, 2020 •

edited

Loading

oliviertassinari commented Jul 6, 2020 •

edited

Loading