Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data grid pro with custom side panel, how to recalculate size on dynamic change of table width? #5555

Closed
2 tasks done
Nikita-Shaked-dev opened this issue Jul 21, 2022 · 5 comments
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists feature: Rendering layout Related to the data grid Rendering engine support: commercial Support request from paid users

Comments

@Nikita-Shaked-dev
Copy link

Nikita-Shaked-dev commented Jul 21, 2022

Order ID 💳

41353

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

The problem in depth 🔍

We have custom panel with detailed info of row, when it's opening table don't recalculate it's own width and scroll doesn`t exist

Also last column disappear, and row has not full width
apiRef`s methods like forceUpdate not helping

steps to reproduce in sandbox:

  1. resize window to fix columns width
  2. click on any row
  3. panel from right side will open
  4. check horizontal scroll of table
  5. resize window
  6. check the horizontal scroll of table

sandbox
Снимок экрана 2022-07-21 в 10 11 55 AM

Your environment 🌎

`npx @mui/envinfo`
  Don't forget to mention which browser you used.
    System:
    OS: macOS 12.4
  Binaries:
    Node: 18.6.0 - /opt/homebrew/bin/node
    Yarn: 1.22.11 - /opt/homebrew/bin/yarn
    npm: 8.13.2 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 103.0.5060.114
    Edge: Not Found
    Firefox: Not Found
    Safari: 15.5
  npmPackages:
    @mui/base:  5.0.0-alpha.89 
    @mui/envinfo: 2.0.6 => 2.0.6 
    @mui/icons-material: ^5.6.1 => 5.8.4 
    @mui/lab: ^5.0.0-alpha.77 => 5.0.0-alpha.90 
    @mui/material: ^5.6.1 => 5.9.0 
    @mui/private-theming:  5.9.0 
    @mui/styled-engine-sc:  5.8.0 
    @mui/system:  5.9.0 
    @mui/types:  7.1.4 
    @mui/utils:  5.9.0 
    @mui/x-data-grid: ^5.8.0 => 5.13.0 
    @mui/x-data-grid-pro: ^5.8.0 => 5.13.0 
    @mui/x-license-pro:  5.12.3 
    @types/react: ^18.0.7 => 18.0.15 
    react: ^18.0.0 => 18.2.0 
    react-dom: ^18.0.0 => 18.2.0 
    styled-components: ^5.3.3 => 5.3.5 
    typescript: ^4.3.2 => 4.7.4 
@Nikita-Shaked-dev Nikita-Shaked-dev added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels Jul 21, 2022
@DanailH
Copy link
Member

DanailH commented Jul 21, 2022

Hey, @Nikita-Shaked-dev thanks for raising this!
I checked your reproduction but I wasn't able to see the issue you are describing. Maybe I'm doing something wrong?

Screen.Recording.2022-07-21.at.11.28.15.mov

@Nikita-Shaked-dev
Copy link
Author

2022-07-22.6.29.59.PM.mov

Hey @DanailH, please look at the video

@alexfauquette alexfauquette added bug 🐛 Something doesn't work duplicate This issue or pull request already exists component: data grid This is the name of the generic UI component, not the React module! feature: Rendering layout Related to the data grid Rendering engine and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 26, 2022
@alexfauquette
Copy link
Member

I'm closing this issue because it has already been fixed by #5566 which will be available in the next release

Here is the cosdesandbox with the fix:
https://codesandbox.io/s/datagridprodemo-demo-mui-x-forked-x25jui?file=/package.json

@Nikita-Shaked-dev
Copy link
Author

@alexfauquette thanks, will it be soon?

@alexfauquette
Copy link
Member

The end of the week or next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists feature: Rendering layout Related to the data grid Rendering engine support: commercial Support request from paid users
Projects
None yet
Development

No branches or pull requests

3 participants