[DataGrid] Fix container width change on React 18 #5566
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5085
Related to #5192
I saw this bug when working in #4155 and one of the tests was failing with React 18 but passing with React 17. By debugging, I noticed that
rootRef.current
was null when theresize
event is fired. I suppose this is happening because the event is triggered while the ref is unmounted. With React 17, the event is fired after the ref is mounted.Before: https://codesandbox.io/s/datagriddemo-demo-mui-x-forked-hw2hd1?file=/demo.tsx
After: https://codesandbox.io/s/datagriddemo-demo-mui-x-forked-s2p48r?file=/package.json
How to reproduce: