Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Keyboard shortcut to select a row (Shift+Space) not working #889

Closed
2 tasks done
wouter-leistra opened this issue Jan 21, 2021 · 3 comments · Fixed by #897
Closed
2 tasks done

[DataGrid] Keyboard shortcut to select a row (Shift+Space) not working #889

wouter-leistra opened this issue Jan 21, 2021 · 3 comments · Fixed by #897
Assignees
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@wouter-leistra
Copy link

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Datagrid renders and a cell has tab focus, using the shortcut SHIFT+SPACE as per docs to select the row, results in nothing to happen. Tested on latest Chrome and Firefox releases.

Expected Behavior 🤔

The row of the cell that had focus after using the shortcut is selected.

Steps to Reproduce 🕹

See current behavior
https://codesandbox.io/s/material-ui-issue-latest-forked-njidy?file=/src/Demo.js

Context 🔦

Aim: Make the datagrid accessible again.

Your Environment 🌎

Chrome: Version 87.0.4280.141 (Official Build) (x86_64)
Firefox: 84.0.2 (64-bit)

`npx @material-ui/envinfo` ``` System: OS: macOS 11.1 Binaries: Node: 14.14.0 - ~/.nvm/versions/node/v14.14.0/bin/node Yarn: 1.21.1 - /usr/local/bin/yarn npm: 6.14.8 - ~/.nvm/versions/node/v14.14.0/bin/npm Browsers: Chrome: 87.0.4280.141 Edge: Not Found Firefox: 84.0.2 Safari: 14.0.2 npmPackages: @material-ui/core: ^4.11.0 => 4.11.0 @material-ui/data-grid: ^4.0.0-alpha.17 => 4.0.0-alpha.17 @material-ui/icons: ^4.9.1 => 4.9.1 @material-ui/lab: ^4.0.0-alpha.56 => 4.0.0-alpha.56 @material-ui/styles: 4.10.0 @material-ui/system: 4.9.14 @material-ui/types: 5.1.0 @material-ui/utils: 4.10.2 @types/react: ^16.9.32 => 16.9.55 react: 16.14.0 => 16.14.0 react-dom: ^16.12.0 => 16.14.0 styled-components: ^5.2.1 => 5.2.1 typescript: ^3.8.3 => 3.9.7 ```
@wouter-leistra wouter-leistra added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 21, 2021
@DanailH
Copy link
Member

DanailH commented Jan 22, 2021

Hi, @wouter-leistra thanks for catching this. I tested it, it is also reproducible on the MUI website.

@DanailH DanailH added breaking change bug 🐛 Something doesn't work accessibility a11y and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer breaking change labels Jan 22, 2021
@DanailH DanailH changed the title Keyboard shortcut to select a row (Shift+Space) not working [DataGrid] Keyboard shortcut to select a row (Shift+Space) not working Jan 22, 2021
@dtassone
Copy link
Member

That's a regression

@oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 22, 2021
dtassone added a commit to dtassone/material-ui-x that referenced this issue Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants