Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix process is not defined (EXPERIMENTAL_ENABLED) #1027

Merged
merged 1 commit into from
Feb 11, 2021
Merged

[DataGrid] Fix process is not defined (EXPERIMENTAL_ENABLED) #1027

merged 1 commit into from
Feb 11, 2021

Conversation

leontastic
Copy link
Contributor

@leontastic leontastic commented Feb 10, 2021 •
edited
Loading

PR for @oliviertassinari to try out his proposed fix for #836

Fixes #836

Alternative PR to #1028

This was referenced Feb 10, 2021
Closed
Closed
@oliviertassinari oliviertassinari changed the title Check if process defined before checking EXPERIMENTAL_ENABLED flag [core] Check if process defined before checking EXPERIMENTAL_ENABLED flag Feb 10, 2021
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Feb 10, 2021
@oliviertassinari oliviertassinari changed the title [core] Check if process defined before checking EXPERIMENTAL_ENABLED flag [DataGrid] Fix process is not defined (EXPERIMENTAL_ENABLED) flag Feb 10, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] Fix process is not defined (EXPERIMENTAL_ENABLED) flag [DataGrid] Fix process is not defined (EXPERIMENTAL_ENABLED) Feb 10, 2021
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Feb 10, 2021
oliviertassinari
oliviertassinari approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, we depend on process.env.NODE_ENV as well. We aren't doing any special treatments for it because React already depends on it, enforcing a constraint we can depend on.

@oliviertassinari oliviertassinari merged commit 693122e into mui:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] ReferenceError: process is not defined
2 participants
@leontastic @oliviertassinari