[DataGrid] Fix checked checkbox when empty rows #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigandy
changed the title
dtassone
approved these changes
Feb 17, 2021
|
Should we add a test case? One on hand we did it wrong in the first place so it's not obvious that we won't introduce a regression in the future, the test could would also be trivial to write. On the other hand, there is no real complexity, so might not worth our time. |
|
@oliviertassinari I can do this. Admittedly it's my first attempt but let me know what you think. |
|
looks great 👍 |
oliviertassinari
added
bug 🐛
bigandy
force-pushed
the
bugfix/checkout-empty-rows
branch
from
09c10dd to
c361a0b
Compare
DanailH
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1066