Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] v7: Move the exports of the calendarHeader slot to @mui/x-date-pickers/PickersCalendarHeader #11020

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 13, 2023

Breaking change

Change the imports of the calendarHeader slot

  • The imports related to the calendarHeader slot have been moved from @mui/x-date-pickers/DateCalendar to @mui/x-date-pickers/PIckersCalendarHeader:

      export {
        pickersCalendarHeaderClasses,
        PickersCalendarHeaderClassKey,
        PickersCalendarHeaderClasses,
        PickersCalendarHeader,
        PickersCalendarHeaderProps,
        PickersCalendarHeaderSlotsComponent,
        PickersCalendarHeaderSlotsComponentsProps,
        ExportedPickersCalendarHeaderProps,
    - } from '@mui/x-date-pickers/DateCalendar';
    + } from '@mui/x-date-pickers/PickersCalendarHeader';

Closes #11019

@flaviendelangle flaviendelangle self-assigned this Nov 13, 2023
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x labels Nov 13, 2023
@mui-bot
Copy link

mui-bot commented Nov 13, 2023

@flaviendelangle flaviendelangle marked this pull request as ready for review November 13, 2023 09:28
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... I'll add the breaking change to the description so it can be read for CHANGELOG generation

@flaviendelangle
Copy link
Member Author

@michelengelen I add the BC just before merging to make sure it's up to date with the migration guide, no need to do it 👍

Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
@michelengelen
Copy link
Member

@michelengelen I add the BC just before merging to make sure it's up to date with the migration guide, no need to do it 👍

Well ... too late! 😂 but I'll remember for the next time!

Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! 🎉

@flaviendelangle flaviendelangle merged commit 522f2c8 into mui:next Nov 14, 2023
5 checks passed
@flaviendelangle flaviendelangle deleted the calendar-header-export branch November 14, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] v7: Move the exports of the calendarHeader slot to @mui/x-date-pickers/PickersCalendarHeader
4 participants