Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Make cell selection feature stable #11246

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[DataGridPremium] Make cell selection feature stable #11246

merged 2 commits into from
Nov 30, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Nov 29, 2023 •
edited
Loading

Part of #10556

TODOs:

  • Add the change to the migration guide and changelog
  • Add a codemod to rename the existing API (follow-up PR)

Changelog

Breaking changes

  • The cell selection feature is now stable.

  • The unstable_ prefix has been removed from the cell selection props listed below.

    Old name New name
    unstable_cellSelection cellSelection
    unstable_cellSelectionModel cellSelectionModel
    unstable_onCellSelectionModelChange onCellSelectionModelChange

  • The unstable_ prefix has been removed from the cell selection API methods listed below.

    Old name New name
    unstable_getCellSelectionModel getCellSelectionModel
    unstable_getSelectedCellsAsArray getSelectedCellsAsArray
    unstable_isCellSelected isCellSelected
    unstable_selectCellRange selectCellRange
    unstable_setCellSelectionModel setCellSelectionModel

@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! v7.x feature: Cell Selection Related to the cell selection feature labels Nov 29, 2023
@mui-bot
Copy link

mui-bot commented Nov 29, 2023 •
edited
Loading

Deploy preview: https://deploy-preview-11246--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against ba8cbfa

@MBilalShafi MBilalShafi mentioned this pull request Nov 29, 2023
Open
45 tasks
michelengelen
michelengelen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBilalShafi MBilalShafi merged commit 26ad59a into mui:next Nov 30, 2023
@MBilalShafi MBilalShafi deleted the breaking-changes/cell-selection branch November 30, 2023 13:17
@MBilalShafi MBilalShafi mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

@michelengelen michelengelen michelengelen approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Cell Selection Related to the cell selection feature v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MBilalShafi @mui-bot @romgrk @michelengelen