-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Do not publish rowEditStop
event if row has fields with errors
#11383
Conversation
Deploy preview: https://deploy-preview-11383--material-ui-x.netlify.app/ |
Does this prevent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super solid! LGTM!
@lauri865 this will only prevent the |
@lauri865 If you're not using |
Let's wait a bit for @lauri865's feedback on this to make sure we're not breaking anything 🙂 |
Great, I'll push this PR forward then!
Could you open a new issue for this discussion? A minimal reproduction example would be great! |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Fixes #11263
TODO: