[DataGrid] Fix checkbox selection keeping selection when filtering #11751
+57
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11751--material-ui-x.netlify.app/ |
zannager
added
the
component: data grid
michelengelen
added
feature: Filtering
|
Thanks @g1mishra for the contribution. |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
1 similar comment
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
cherniavskii
added
bug 🐛
github-actions bot
pushed a commit
that referenced
this pull request
Mar 18, 2024
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
cherniavskii
changed the title
1 task
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Co-authored-by: Andrew Cherniavskyi <andrew@mui.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11726
Preview https://deploy-preview-11751--material-ui-x.netlify.app/x/react-data-grid/row-selection/#checkbox-selection
Issue:
When all rows were selected, and a filter was applied, the
handleHeaderSelectionCheckboxChangefunction'sonClickevent for theallSelectcheckbox was deselecting only the filtered rows. Non-filtered selected rows were retained in the state.Solution:
To address this issue, modifications were made to the
handleHeaderSelectionCheckboxChangefunction. With a filter applied, I pass the third argument toselectRowsto ensure that deselection also considers non-filtered selected rows.