Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add shift as multiple key #1203

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[DataGrid] Add shift as multiple key #1203

merged 1 commit into from
Mar 11, 2021

Conversation

dtassone
Copy link
Member

fix #1202

@dtassone dtassone merged commit 0314e87 into mui:master Mar 11, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 11, 2021 •
edited
Loading

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 11, 2021 •
edited
Loading

Actually, the GRID_MULTIPLE_SELECTION_KEYS logic is not working. It's bound to the grid root, not the window. It could check the event directly to solve it.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 11, 2021 •
edited
Loading

I'm opening a new issue: #1204.

@oliviertassinari oliviertassinari changed the title [DataGrid] add shift as multiple key [DataGrid] Add shift as multiple key Mar 11, 2021
@oliviertassinari oliviertassinari mentioned this pull request Mar 13, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanailH DanailH DanailH approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DataGrid] Add shift as multiple key
3 participants
@dtassone @oliviertassinari @DanailH