[TreeView] Add public API and expose focus method #12143
Merged
+543
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noraleonte
added
the
component: tree view
2 tasks
packages/x-tree-view/src/internals/utils/extractPluginParamsFromProps.ts
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/utils/extractPluginParamsFromProps.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
It a great DX improvement 👌
We are missing a few tests (you can put them in SimpleTreeVIew.test.tsx, I need to split the test file and see how we can run them on both SimpleTreeView and RichTreeView without duplicating everything).
And the doc page should probably be copied on the RichTreeView doc once ready.
docs/data/tree-view/simple-tree-view/focus/FocusedSimpleTreeView.tsx
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/focus/FocusedSimpleTreeView.tsx
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewFocus/useTreeViewFocus.types.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com> Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com>
packages/x-tree-view/src/internals/plugins/useTreeViewFocus/useTreeViewFocus.ts
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/plugins/useTreeViewFocus/useTreeViewFocus.ts
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/useTreeView/useTreeView.types.ts
Outdated
Show resolved
Hide resolved
packages/x-tree-view/src/internals/useTreeView/useTreeView.utils.ts
Outdated
Show resolved
Hide resolved
flaviendelangle
approved these changes
Feb 28, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Nora <72460825+noraleonte@users.noreply.github.com> Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10236