-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[code-infra] Use the @mui/internal-markdown package #12188
Conversation
Deploy preview: https://deploy-preview-12188--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
b362239
to
e32b7b8
Compare
f6ed9e8
to
e32b7b8
Compare
The failing builds seem not to be related to my changes. @mui/x, are they "expected" (based on other changes you've done since the last monorepo update)? |
@michaldudak It seems to be related to this modification in core. https://github.com/mui/material-ui/pull/39137/files#r1501919356 I'm trying the fix here #12105 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Done in #12105 |
Used the @mui/internal-markdown package from npm instead of the monorepo.
Renamed all the references from @mui/markdown to @mui/internal-markdown.
Uses changes from mui/material-ui#41240.
This bumps the Core monorepo reference to the latest master. I also had to update the Core packages the make the build pass.