Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Use the @mui/internal-markdown package #12188

Closed
wants to merge 6 commits into from

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Feb 23, 2024

Used the @mui/internal-markdown package from npm instead of the monorepo.
Renamed all the references from @mui/markdown to @mui/internal-markdown.

Uses changes from mui/material-ui#41240.

This bumps the Core monorepo reference to the latest master. I also had to update the Core packages the make the build pass.

@mui-bot
Copy link

mui-bot commented Feb 23, 2024

Deploy preview: https://deploy-preview-12188--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against cd90dcf

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 23, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 26, 2024
@michaldudak michaldudak marked this pull request as ready for review February 26, 2024 13:43
@michaldudak
Copy link
Member Author

michaldudak commented Feb 26, 2024

The failing builds seem not to be related to my changes. @mui/x, are they "expected" (based on other changes you've done since the last monorepo update)?

@alexfauquette
Copy link
Member

The failing builds seem not to be related to my changes. @mui/x, are they "expected" (based on other changes you've done since the last monorepo update)?

@michaldudak It seems to be related to this modification in core.

https://github.com/mui/material-ui/pull/39137/files#r1501919356

I'm trying the fix here #12105

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 2, 2024
Copy link

github-actions bot commented Mar 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alexfauquette
Copy link
Member

Done in #12105

@michaldudak michaldudak deleted the core-integration/41240 branch March 20, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: out-of-date The pull request has merge conflicts and can't be merged scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants