Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix linking to sorting component in data-grid overview page #1237

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[docs] Fix linking to sorting component in data-grid overview page #1237

merged 1 commit into from
Mar 18, 2021

Conversation

SaskiaKeil
Copy link
Contributor

@SaskiaKeil SaskiaKeil commented Mar 15, 2021

Fix #1236.

Wrong link to sorting docs in overview page: https://material-ui.com/components/data-grid/
Sorting & Multi Column Sorting lead to the row page since the sorting content moved to a new page.

Updated the reference to point to the dedicated sorting section.

@oliviertassinari
Copy link
Member

We broke it in #931. We forgot about these cross-links.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 16, 2021

I have updated the pull request description to automatically close the linked issue. I think that we can make this a habit:

Screenshot 2021-03-16 at 23 15 22

Screenshot 2021-03-16 at 23 16 14

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Mar 16, 2021
@dtassone dtassone merged commit c599da9 into mui:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Wrong link to sorting docs in overview page
4 participants