Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix Popper z-index #1240

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

m4theushw
Copy link
Member

@m4theushw m4theushw commented Mar 16, 2021

One chunk of #844

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels Mar 16, 2021
@oliviertassinari
Copy link
Member

The updated reproduction with the latest commit of the PR: https://codesandbox.io/s/affectionate-tereshkova-tphdf?file=/package.json.

@TodBob
Copy link

TodBob commented Mar 19, 2021

The thing is, probably not related with this fix. Filter is not working. You can't type anything in value input.
https://codesandbox.io/s/affectionate-tereshkova-tphdf?file=/package.json.

In MUI 4.11.1 if I test demo from docs. Filter is not working, value input seems disabled or something.

@m4theushw
Copy link
Member Author

m4theushw commented Mar 19, 2021

@TomasKomprs That is because the TrapFocus keeps moving the focus to the Dialog. It's fixed in v5. To work with v4 see this comment.

@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 19, 2021

It seems that we didn't yet get any volunteers to take ownership of the problem by the action of merging this PR. It looks great, @m4theushw do you want to do it? :)

@m4theushw m4theushw merged commit a46e2a1 into mui:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants