Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Make rows an optional prop #12478

Merged
merged 7 commits into from
Mar 20, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Mar 18, 2024

Since https://stackblitz.com/edit/react-fgjyv2?file=Demo.tsx is a valid use-case, we could make rows prop an optional one for the use cases like #12317 or when someone wants to imperatively set the rows instead of passing a prop.

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! typescript dx Related to developers' experience labels Mar 18, 2024
@mui-bot
Copy link

mui-bot commented Mar 18, 2024

Deploy preview: https://deploy-preview-12478--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 8cfcc0c

@MBilalShafi MBilalShafi marked this pull request as ready for review March 19, 2024 14:53
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2024
@MBilalShafi MBilalShafi merged commit ce28aa1 into mui:next Mar 20, 2024
17 checks passed
@MBilalShafi MBilalShafi deleted the rows-optional-prop branch April 17, 2024 11:30
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants