[fields] Fix input refocusing after clearing a value #12587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
regression
|
Deploy preview: https://deploy-preview-12587--material-ui-x.netlify.app/ |
flaviendelangle
approved these changes
Mar 28, 2024
|
|
||
| if (!interactions.isFieldFocused) { | ||
| if (!interactions.isFieldFocused()) { |
There was a problem hiding this comment.
🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦
Thanks for fixing it
There was a problem hiding this comment.
P.S. Didn't want to risk it again, that's why I took a bit longer than expected. 🙈
At first, I tried tailoring a unit test—which proved to be nearly impossible to achieve reliably.
Then, I resorted to writing an e2e test, which also posed challenges due to Firefox's getSelection behavior... 🙈 🤷
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12574
isFieldFocusedfunction instead of only checking it's existence