Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Create RichTreeViewPro component #12610

Merged
merged 16 commits into from
Apr 4, 2024
Merged

[TreeView] Create RichTreeViewPro component #12610

merged 16 commits into from
Apr 4, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Mar 29, 2024 •
edited
Loading

Follow up on #12240

@flaviendelangle flaviendelangle self-assigned this Mar 29, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Mar 29, 2024
@flaviendelangle flaviendelangle changed the title [TreeView] Create RichTreeViewPro component [TreeView] Create RichTreeViewPro component Mar 29, 2024
@mui-bot
Copy link

mui-bot commented Mar 29, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12610--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 29e7e90

@flaviendelangle flaviendelangle marked this pull request as ready for review April 3, 2024 12:49
flaviendelangle
flaviendelangle commented Apr 3, 2024
View reviewed changes
packages/x-tree-view/src/SimpleTreeView/SimpleTreeView.tsx
@@ -36,6 +36,7 @@ export const SimpleTreeViewRoot = styled('ul', {
margin: 0,
listStyle: 'none',
outline: 0,
position: 'relative',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need this for the RichTreeViewPro otherwise the watermark is placed outside of the component.
I added it to RichTreeView and SimpleTreeView as well for consistency.

michelengelen
michelengelen approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LukasTy
LukasTy approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
The only thing to consider is the themeAugmentation. 😉

packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.tsx Outdated Show resolved Hide resolved
packages/x-tree-view-pro/src/RichTreeViewPro/RichTreeViewPro.types.ts Outdated Show resolved Hide resolved
packages/x-tree-view-pro/src/index.ts Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you considered adding this project to the createXTypeScriptProjects list to track the exports evolution? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would add the interfaces to the doc
We could add a "private" option (or check the package.json) to only generate the exports file, I do agree it would be useful.

@flaviendelangle
Copy link
Member Author

flaviendelangle commented Apr 3, 2024 •
edited
Loading

The only thing to consider is the themeAugmentation

I forgot to add it 😬

EDIT: Done

flaviendelangle and others added 8 commits April 3, 2024 17:11
@flaviendelangle flaviendelangle merged commit fdffa6a into mui:master Apr 4, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the create-RichTreeViewPro branch April 4, 2024 08:43
LukasTy
LukasTy reviewed Apr 4, 2024
View reviewed changes
packages/x-tree-view-pro/src/themeAugmentation/index.js
@@ -0,0 +1 @@
// Prefer to use `import type {} from '@mui/x-tree-view/themeAugmentation';` instead to avoid importing an empty file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick:

- @mui/x-tree-view/themeAugmentation
+ @mui/x-tree-view-pro/themeAugmentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#12674

@flaviendelangle flaviendelangle mentioned this pull request Apr 4, 2024
Merged
4 tasks
@alexfauquette alexfauquette mentioned this pull request May 20, 2024
Merged
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@flaviendelangle @LukasTy @DungTiger
[TreeView] Create RichTreeViewPro component (mui#12610)
8acf143 
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@flaviendelangle @LukasTy @thomasmoon
[TreeView] Create RichTreeViewPro component (mui#12610)
23034ad 
Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@michelengelen michelengelen michelengelen approved these changes

@noraleonte noraleonte Awaiting requested review from noraleonte

Assignees

@flaviendelangle flaviendelangle

Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaviendelangle @mui-bot @LukasTy @michelengelen