Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Use describeTreeView for focus tests #12698

Merged

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Apr 8, 2024

Part of #12433

A lot of the tests will be in useTreeViewKeyboardNavigation.test.tsx

I removed some tests that made no sense now that the focus is on the item instead of the root.

@flaviendelangle flaviendelangle self-assigned this Apr 8, 2024
@flaviendelangle flaviendelangle added core Infrastructure work going on behind the scenes component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Apr 8, 2024
@mui-bot
Copy link

mui-bot commented Apr 8, 2024

Deploy preview: https://deploy-preview-12698--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 91de4d8

@flaviendelangle flaviendelangle changed the title [core] Use for focus tests [core] Use describeTreeView for focus tests Apr 8, 2024
@flaviendelangle flaviendelangle force-pushed the useTreeViewFocus-describeTreeView branch 2 times, most recently from dffe112 to faa6f9c Compare April 8, 2024 10:40
@flaviendelangle flaviendelangle force-pushed the useTreeViewFocus-describeTreeView branch from faa6f9c to b593878 Compare April 8, 2024 10:54
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 8, 2024
Copy link

github-actions bot commented Apr 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 8, 2024
Copy link

github-actions bot commented Apr 9, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Apr 9, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 11, 2024
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🎉

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@flaviendelangle flaviendelangle merged commit f3b5f1b into mui:master Apr 19, 2024
15 checks passed
@flaviendelangle flaviendelangle deleted the useTreeViewFocus-describeTreeView branch April 19, 2024 11:25
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants