-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use describeTreeView
for focus tests
#12698
[core] Use describeTreeView
for focus tests
#12698
Conversation
Deploy preview: https://deploy-preview-12698--material-ui-x.netlify.app/ |
describeTreeView
for focus tests
dffe112
to
faa6f9c
Compare
faa6f9c
to
b593878
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Part of #12433
A lot of the tests will be in
useTreeViewKeyboardNavigation.test.tsx
I removed some tests that made no sense now that the focus is on the item instead of the root.