Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix date filtering for negative timezone offsets #12836

Merged
merged 1 commit into from
Apr 19, 2024
Merged

[DataGrid] Fix date filtering for negative timezone offsets #12836

merged 1 commit into from
Apr 19, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Apr 18, 2024 •
edited
Loading

@cherniavskii cherniavskii added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse feature: Filtering Related to the data grid Filtering feature labels Apr 18, 2024
@mui-bot
Copy link

mui-bot commented Apr 18, 2024

Deploy preview: https://deploy-preview-12836--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 286352a

@cherniavskii cherniavskii mentioned this pull request Apr 18, 2024
Closed
@cherniavskii cherniavskii marked this pull request as ready for review April 19, 2024 09:17
michelengelen
michelengelen approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@cherniavskii cherniavskii merged commit fc8524e into mui:master Apr 19, 2024
20 checks passed
@cherniavskii cherniavskii deleted the fix-date-filtering-for-negative-offset branch April 19, 2024 12:45
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@cherniavskii @DungTiger
[DataGrid] Fix date filtering for negative timezone offsets (mui#12836)
abf821b
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@cherniavskii @thomasmoon
[DataGrid] Fix date filtering for negative timezone offsets (mui#12836)
f715d55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@MBilalShafi MBilalShafi MBilalShafi approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Date filtering with negative timezone offset
4 participants
@cherniavskii @mui-bot @MBilalShafi @michelengelen