Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document missing Charts API's #12875

Merged
merged 3 commits into from
May 15, 2024
Merged

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Apr 23, 2024

Pick mui/material-ui#42004

The ChartsXAxis and ChartsYAxis where not documented because the regexp looking if a function is a component did not accepted 2 capital letters next to each over (refused ChartsXAxis)

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels May 14, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 14, 2024
@mui-bot
Copy link

mui-bot commented May 14, 2024

Deploy preview: https://deploy-preview-12875--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 6a501c3

@alexfauquette alexfauquette marked this pull request as ready for review May 14, 2024 14:00
@LukasTy LukasTy changed the title [charts] Document more API's [docs] Document missing Charts API's May 14, 2024
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! 👍 👏

Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also fix the regexp to prevent future issues?

@alexfauquette
Copy link
Member Author

Should we also fix the regexp to prevent future issues?

The https://github.com/mui/material-ui/pull/42004/files is the fix of the Regexp ;)

@alexfauquette alexfauquette merged commit d3c13f9 into mui:master May 15, 2024
17 checks passed
arthurbalduini pushed a commit to arthurbalduini/mui-x that referenced this pull request May 23, 2024
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants