-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Document missing Charts API's #12875
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Deploy preview: https://deploy-preview-12875--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! 👍 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also fix the regexp to prevent future issues?
The https://github.com/mui/material-ui/pull/42004/files is the fix of the Regexp ;) |
Pick mui/material-ui#42004
The
ChartsXAxis
andChartsYAxis
where not documented because the regexp looking if a function is a component did not accepted 2 capital letters next to each over (refused ChartsXAxis)