-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Add AdapterDateFnsJalaliV3
adapter
#12891
Conversation
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
9afed0a
to
1018a20
Compare
I found the problem with the Babel config. the - _ref2.filename.includes('AdapterDateFnsV3.ts')
+ _ref2.filename.includes(_ref2.opts.filenameIncludes || '') |
I hope this pull request is ready for review. I tried to have well-separated commits, especially separated copy and rename commits will help in the review process |
Deploy preview: https://deploy-preview-12891--material-ui-x.netlify.app/ Updated pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Massive thank you for your contribution @smmoosavi! 🙏
I took the liberty to update the code and add a documentation enhancement to show the usage of the v3 adapter. 😉
P.S. This adapter will be released with the next v7 release.
If there are enough requests, we can back-port it to v6. 😉
Does that make sense? 🤔
AdapterDateFnsJalaliV3
adapter
Thanks.
yes. |
@@ -58,7 +58,7 @@ | |||
"core-js": "^2.6.12", | |||
"cross-env": "^7.0.3", | |||
"date-fns": "^2.30.0", | |||
"date-fns-jalali": "^2.21.3-1", | |||
"date-fns-jalali": "^2.30.0-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely, it has not been picked up by renovate...
The version format could be to blame. 🙈
@@ -195,7 +196,6 @@ | |||
"packageManager": "pnpm@8.15.8", | |||
"pnpm": { | |||
"patchedDependencies": { | |||
"date-fns-jalali@2.13.0-0": "patches/date-fns-jalali@2.13.0-0.patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not seem needed anymore! 👏 🥳
@@ -103,7 +103,7 @@ | |||
"@types/moment-jalaali": "^0.7.9", | |||
"@types/prop-types": "^15.7.12", | |||
"date-fns": "^2.30.0", | |||
"date-fns-jalali": "^2.13.0-0", | |||
"date-fns-jalali": "^2.30.0-0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to bump the version to have the exported date-fns-jalali/locale/types
file so the build would pass.
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
AdapterDateFnsJalaliV3
I am trying to add
AdapterDateFnsJalaliV3
tox-date-pickers
babel config problem. solved
but I have a problem with the Babel config to replace `date-fns-jalali` with `date-fns-jalali-v3`. can anyone help to fix the problem?