Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Rename missed modules #1292

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Mar 25, 2021

Fixes #1260

I skipped ElementSize and InternalGridRowsState as I don't think that they are usable even tho they are public.

@DanailH DanailH added breaking change component: data grid This is the name of the generic UI component, not the React module! labels Mar 25, 2021
@DanailH DanailH self-assigned this Mar 25, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 26, 2021

I skipped ElementSize and InternalGridRowsState as I don't think that they are usable even tho they are public.

At some point, could we look into how to not export them to the developers? Maybe it's simple enough to take care of it here? For instance, it seems as simple as:

diff --git a/packages/grid/_modules_/grid/models/index.ts b/packages/grid/_modules_/grid/models/index.ts
index 4d85995e..42cff737 100644
--- a/packages/grid/_modules_/grid/models/index.ts
+++ b/packages/grid/_modules_/grid/models/index.ts
@@ -1,6 +1,5 @@
 export * from './colDef';
 export * from './gridContainerProps';
-export * from './elementSize';
 export * from './gridEditRowModel';
 export * from './gridFeatureMode';
 export * from './gridFilterItem';
 diff --git a/packages/grid/_modules_/grid/components/GridStickyContainer.tsx b/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
index dc1c24a7..8a512aea 100644
--- a/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
+++ b/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
@@ -1,5 +1,5 @@
 import * as React from 'react';
-import { ElementSize } from '../models';
+import { ElementSize } from '../models/elementSize';

@DanailH
Copy link
Member Author

DanailH commented Mar 26, 2021

@oliviertassinari I agree, I'll just remove it now and it would be nice to audit again and clean up what is exported and what not.

@oliviertassinari
Copy link
Member

For the audit, rebasing #1212 on HEAD might be enough. I did work on #1259 for this very problem.

@DanailH DanailH force-pushed the fix/DataGrid-1260-renaming-missed-modules branch from e806a86 to 094feb1 Compare March 29, 2021 09:52
@DanailH DanailH requested a review from dtassone March 29, 2021 09:53
@DanailH DanailH merged commit 728bad3 into mui:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Modules we missed in #169
3 participants