-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Rename missed modules #1292
Merged
DanailH
merged 2 commits into
mui:master
from
DanailH:fix/DataGrid-1260-renaming-missed-modules
Mar 31, 2021
Merged
[DataGrid] Rename missed modules #1292
DanailH
merged 2 commits into
mui:master
from
DanailH:fix/DataGrid-1260-renaming-missed-modules
Mar 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanailH
added
breaking change
component: data grid
This is the name of the generic UI component, not the React module!
labels
Mar 25, 2021
dtassone
reviewed
Mar 25, 2021
packages/grid/_modules_/grid/hooks/features/filter/useGridFilter.ts
Outdated
Show resolved
Hide resolved
At some point, could we look into how to not export them to the developers? Maybe it's simple enough to take care of it here? For instance, it seems as simple as: diff --git a/packages/grid/_modules_/grid/models/index.ts b/packages/grid/_modules_/grid/models/index.ts
index 4d85995e..42cff737 100644
--- a/packages/grid/_modules_/grid/models/index.ts
+++ b/packages/grid/_modules_/grid/models/index.ts
@@ -1,6 +1,5 @@
export * from './colDef';
export * from './gridContainerProps';
-export * from './elementSize';
export * from './gridEditRowModel';
export * from './gridFeatureMode';
export * from './gridFilterItem';
diff --git a/packages/grid/_modules_/grid/components/GridStickyContainer.tsx b/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
index dc1c24a7..8a512aea 100644
--- a/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
+++ b/packages/grid/_modules_/grid/components/GridStickyContainer.tsx
@@ -1,5 +1,5 @@
import * as React from 'react';
-import { ElementSize } from '../models';
+import { ElementSize } from '../models/elementSize'; |
oliviertassinari
approved these changes
Mar 26, 2021
@oliviertassinari I agree, I'll just remove it now and it would be nice to audit again and clean up what is exported and what not. |
dtassone
reviewed
Mar 26, 2021
DanailH
force-pushed
the
fix/DataGrid-1260-renaming-missed-modules
branch
from
March 29, 2021 09:52
e806a86
to
094feb1
Compare
dtassone
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: data grid
This is the name of the generic UI component, not the React module!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1260
I skipped
ElementSize
andInternalGridRowsState
as I don't think that they are usable even tho they are public.