Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPremium] Fix print export not working with row grouping #12957

Merged
merged 5 commits into from
May 2, 2024
Merged

[DataGridPremium] Fix print export not working with row grouping #12957

merged 5 commits into from
May 2, 2024

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Apr 30, 2024 •
edited by michelengelen
Loading

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! regression A bug, but worse labels Apr 30, 2024
@mui-bot
Copy link

mui-bot commented Apr 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-12957--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 11a20c6

MBilalShafi
MBilalShafi commented Apr 30, 2024
View reviewed changes
packages/x-data-grid/src/hooks/features/sorting/gridSortingSelector.ts Outdated
acc.push({ id, model });
}
const rowNode = rowTree[id];
if (isAutoGeneratedRow(rowNode)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To align with

mui-x/packages/x-data-grid/src/hooks/features/rows/useGridRows.ts

Lines 103 to 106 in ad0c9bf

const node = apiRef.current.getRowNode(id);
if (node && isAutoGeneratedRow(node)) {
return { [GRID_ID_AUTOGENERATED]: id };
}

@MBilalShafi MBilalShafi mentioned this pull request Apr 30, 2024
Closed
@MBilalShafi MBilalShafi marked this pull request as draft April 30, 2024 18:09
@MBilalShafi
Copy link
Member Author

MBilalShafi commented Apr 30, 2024 •
edited
Loading

Update: There's still difference with the v6 version, for example with: https://v6.mui.com/x/react-data-grid/row-grouping/#grouping-rows-with-custom-cell-renderer
I will try to fix it

@MBilalShafi MBilalShafi marked this pull request as ready for review May 1, 2024 23:08
@MBilalShafi
Copy link
Member Author

Update: The pull request is ready for review.

michelengelen
michelengelen approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MBilalShafi MBilalShafi merged commit f895c93 into mui:master May 2, 2024
17 checks passed
@MBilalShafi MBilalShafi deleted the print-export-regression branch May 2, 2024 11:20
@Crihojames Crihojames mentioned this pull request Jun 1, 2024
Open
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@MBilalShafi @DungTiger
[DataGridPremium] Fix print export not working with row grouping (mui…
76757c3 
…#12957)
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
@MBilalShafi @thomasmoon
[DataGridPremium] Fix print export not working with row grouping (mui…
dd74279 
…#12957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelengelen michelengelen michelengelen approved these changes

@romgrk romgrk Awaiting requested review from romgrk

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! feature: Export regression A bug, but worse
Projects
None yet
Milestone
No milestone
3 participants
@MBilalShafi @mui-bot @michelengelen