Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Fix automated reviewers assignment workflow #12986

Merged
merged 2 commits into from
May 3, 2024

Conversation

michelengelen
Copy link
Member


Fix for the broken workflow applied in #12982

@michelengelen michelengelen added the scope: infra Org infrastructure work going on behind the scenes label May 3, 2024
@michelengelen michelengelen self-assigned this May 3, 2024
@mui-bot
Copy link

mui-bot commented May 3, 2024

Deploy preview: https://deploy-preview-12986--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3eb2cdf

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although, I haven't tested it or gone line by line. 🙈

.github/workflows/add-release-reviewers.yml Outdated Show resolved Hide resolved
@LukasTy LukasTy changed the title [infra] fix automated reviewers assignment workflow [infra] Fix automated reviewers assignment workflow May 3, 2024
@michelengelen michelengelen requested review from LukasTy and JCQuintas May 3, 2024 15:37
@michelengelen michelengelen enabled auto-merge (squash) May 3, 2024 15:47
@JCQuintas JCQuintas added release We are shipping :D and removed release We are shipping :D labels May 3, 2024
@michelengelen michelengelen merged commit 7fe71c7 into mui:master May 3, 2024
17 of 18 checks passed
@JCQuintas
Copy link
Member

LGTM, although, I haven't tested it or gone line by line. 🙈

Only way to test CI is to have the green ✓

DATA=$(gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/${{ORG}}/teams/${{TEAM_SLUG}}/members \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding this error:
https://github.com/mui/mui-x/actions/runs/8941961408

I guess that you should use $ORG or ${{ env.ORG }} instead of ${{ORG}} 😅

DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants