Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Reduce bundle size with error messages #12992

Merged
merged 2 commits into from
May 10, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 4, 2024

@oliviertassinari oliviertassinari added performance component: data grid This is the name of the generic UI component, not the React module! labels May 4, 2024
@mui-bot
Copy link

mui-bot commented May 4, 2024

Deploy preview: https://deploy-preview-12992--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 74a532a

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree these validation errors should not be needed in production 👍

@oliviertassinari oliviertassinari added the regression A bug, but worse label May 4, 2024
@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 4, 2024

I pushed a new commit, it didn't work, let's see if this is enough.

Edit: It seems to be good. Asking for review from Alexandre as it's a follow-up on #11303.

@LukasTy LukasTy changed the title [data grid] Reduce bundle size with error messages [DataGrid] Reduce bundle size with error messages May 6, 2024
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

With component stacks, we should be able to replace propTypes completely 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! performance regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants