[DataGrid] Fix print export failure when hideFooter option is set
#13034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunrajput
changed the title
tarunrajput
force-pushed
the
fix/usePrintGridExport
branch
from
5330d84
to
6456fda
Compare
tarunrajput
changed the title
zannager
added
the
component: data grid
|
@michelengelen, mind taking a look? |
michelengelen
requested changes
May 28, 2024
packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
Outdated
Show resolved
Hide resolved
|
@cherniavskii or @MBilalShafi gentle ping on this one! |
tarunrajput
force-pushed
the
fix/usePrintGridExport
branch
from
6456fda
to
d241433
Compare
MBilalShafi
reviewed
May 31, 2024
packages/x-data-grid/src/hooks/features/export/useGridPrintExport.tsx
Outdated
Show resolved
Hide resolved
MBilalShafi
changed the title
hideFooter option is set
MBilalShafi
approved these changes
Jun 22, 2024
|
Deploy preview: https://deploy-preview-13034--material-ui-x.netlify.app/ |
sry for the block! 👍🏻
This was referenced Jul 20, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
…ui#13034) Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
This was referenced Jul 27, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
…ui#13034) Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13015
When
hideFooteroption is true, grid footer is not rendered anymore. This PR adds a check to skip styling the grid footer element in that case.